[15.0][IMP] sign_oca: Filter unsigned documents in user count #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ("signed_on", "=", False) to sign_oca_request_user_count domain
- Ensures only unsigned documents are counted
- Improves accuracy of pending signature notifications
- Prevents signed documents from appearing in user's to-sign list
|
Hi @etobella, |
|
This PR looks fantastic, let's merge it! |
etobella
approved these changes
Sep 13, 2024
|
Congratulations, your PR was merged at e7b945a. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
15.0-imp-sign_oca-sign_oca_request_user_count
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWP from 14.0: #61
Filter unsigned documents in user count
Add ("signed_on", "=", False) to sign_oca_request_user_count domain