Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] sign_oca: Migration to 17.0 #70

Draft
wants to merge 70 commits into
base: 17.0
Choose a base branch
from

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Oct 31, 2024

Supersedes #33

Migration to 17.0

@Tecnativa TT51500

etobella and others added 30 commits October 31, 2024 14:27
[BOT] post-merge updates
[UPD] Update sign_oca.pot
Translated using Weblate (Italian)

Currently translated at 28.2% (48 of 170 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (170 of 170 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
[UPD] Update sign_oca.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/
Currently translated at 100.0% (170 of 170 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (170 of 170 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
[UPD] Update sign_oca.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/
1. Add Sign button in request form (it was only in tree view).
2. Fix configure template action when it is created from a request.
- Load 'required' field in configure dialog
- Show 'required' fields in red in configure mode
- Load 'role_id' field in configure dialog
Unify to_sign and signer_is_allow_signature fields which had the same purpose
BernatPForgeFlow and others added 19 commits October 31, 2024 14:27
Once the request is completely signed, all the signers should receive a copy of the final document.

[UPD] Update sign_oca.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/

[BOT] post-merge updates
Currently translated at 100.0% (204 of 204 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
Before this commit
------------------

Internal user cannot sign a document if this user's partner is a child of some other partner.

Example:
User "Pepe Frog" has a partner "Meme Inc, Pepe Frog" set as `user.partner_id`.
This is because partner "Meme Inc" is set as a company for the partner "Pepe Frog".
So when user Pepe Frog is assigned to a sign request he cannot see the "Sign" button.

After this commit
-----------------

User can see the "Sign" button and sign documents even if related partner has a parent partner set.

[BOT] post-merge updates
Only "advanced" users have read access to ir.model, for this reason, we need to apply .sudo()

[BOT] post-merge updates
[BOT] post-merge updates
Currently translated at 100.0% (204 of 204 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
[UPD] Update sign_oca.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/
Currently translated at 100.0% (209 of 209 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
Add ("signed_on", "=", False) to sign_oca_request_user_count domain
- Ensures only unsigned documents are counted
- Improves accuracy of pending signature notifications
- Prevents signed documents from appearing in user's to-sign list

[BOT] post-merge updates
WARNING devel odoo.addons.base.models.ir_model: Two fields (signer_id, signer_ids)
of sign.oca.request() have the same label: Signer. [Modules: sign_oca and sign_oca]

[UPD] Update sign_oca.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/
TT41745

[UPD] Update sign_oca.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/
Currently translated at 100.0% (211 of 211 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
Currently translated at 93.8% (198 of 211 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/es/
[UPD] Update sign_oca.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/
@pedrobaeza
Copy link
Member

/ocabot migration sign_oca

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 31, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 31, 2024
1 task
@victoralmau victoralmau force-pushed the 17.0-mig-sign_oca branch 2 times, most recently from 802230a to 2836af4 Compare November 7, 2024 16:23
victoralmau and others added 4 commits November 11, 2024 15:27
… sent to the signers so that everyone can sign

Example use case:
- Create a request
- Define 2 different signers
- Click on the Send button
- 2 emails will be sent and each one will have the correct url in the Sign document button

Fixes OCA#71
>
>
Co-authored-by: Bernat Puig <bernat.puig@forgeflow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.