Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] spreadsheet_oca: Add manager group to default user template #56

Closed
wants to merge 1 commit into from

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Jan 24, 2025

Adds the manager group to the default user template

@tarteo tarteo force-pushed the 16-imp-add-group-to-tmpl branch from 95e3854 to cdf7c42 Compare January 24, 2025 13:13
@pedrobaeza
Copy link
Member

I don't think by default every new user should be spreadsheet manager.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jan 24, 2025
@tarteo
Copy link
Member Author

tarteo commented Jan 24, 2025

Hey @pedrobaeza, the idea is to add it to the template by default. This can be changed of course after installation by an administrator as the template is noupdate . But what this solves is when somebody besides base.user_admin installs the module it should appear for them out of the box. Which is IMO the desired behaviour, but opinions can be different let see what other people think 😄 Same for OCA/vertical-association#192

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said, I don't agree with that. If you want it in the administrator user, put it there, not in the default.

@tarteo
Copy link
Member Author

tarteo commented Jan 24, 2025

I think this is also what Odoo intents, but it's fine I close this and put it in a non-oca module. As it probably never gets merged anyways https://github.com/odoo/odoo/blob/f5005390b5e07330a8fd7ee7160e7f3e94eab46a/addons/account/security/account_security.xml#L133

@tarteo tarteo closed this Jan 24, 2025
@pedrobaeza
Copy link
Member

I prefer a policy to deny by default to the new users. If not, if you are not aware, any new user will see everything in your ERP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants