[16.0][MIG] stock_request_analytic: Migration to 16.0 #16

victoralmau · 2024-03-26T07:40:23Z

Superseed #3

Migration to 16.0

Changes done:

Analytic_account_id field is removed from stock.request (and all related).
Added analytic_distribution field to stock.request.

Please @chienandalu and @pedrobaeza can you review it?

* clean views. * allow to create a stock.request with no analytic account. * remove copy attribute in non-stored field. * remove non-existing field from compute method.

…rrors

Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (8 of 8 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_analytic Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_analytic/zh_CN/

Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (8 of 8 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_analytic Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_analytic/pt_BR/

TT28488

Co-authored-by: Pimolnat Suntian <pimolnats@ecosoft.co.th> TT28896 [UPD] Update stock_request_analytic.pot [UPD] README.rst

…rders

…nt values If procurement will trigger a purchase and not a move, there is no mean to transmit it (e.g.: to purchase). [UPD] Update stock_request_analytic.pot [UPD] README.rst stock_request_analytic 14.0.1.0.1

stock_request_analytic 14.0.1.0.2

Currently translated at 100.0% (9 of 9 strings) Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_request_analytic Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_request_analytic/pt_BR/

[UPD] README.rst stock_request_analytic 14.0.1.0.3

[UPD] Update stock_request_analytic.pot [UPD] README.rst stock_request_analytic 15.0.1.0.1 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_request_analytic Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_request_analytic/

Translated using Weblate (Spanish) Currently translated at 41.6% (5 of 12 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_request_analytic Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_request_analytic/es/ Translated using Weblate (Spanish) Currently translated at 100.0% (12 of 12 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_request_analytic Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_request_analytic/es/ [UPD] README.rst

…to avoid permissions errors [BOT] post-merge updates

Translated using Weblate (Italian) Currently translated at 100.0% (12 of 12 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_request_analytic Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_request_analytic/it/

Changes done: - Analytic_account_id field is removed from stock.request (and all related). - Added analytic_distribution field to stock.request. TT47865 Co-authored-by: Urvisha-OSI

pedrobaeza · 2024-03-26T07:47:23Z

/ocabot migration stock_request_analytic

OCA-git-bot · 2024-03-26T07:47:29Z

There's no issue in this repo with the title 'Migration to version 16.0' and the milestone 16.0, so not possible to add the comment.

pedrobaeza

Migration scripts are missing. Check https://github.com/OCA/openupgradelib/blob/master/openupgradelib/openupgrade_160.py#L418

pedrobaeza · 2024-03-26T07:49:39Z

stock_request_analytic/models/analytic.py

-class AccountAnalyticAccount(models.Model):
-    _inherit = "account.analytic.account"
-
-    stock_request_ids = fields.One2many(


Why removing this? I think it's still useful, but it should be computed and extracted from the analytic distributions.

The analytical distribution is done at each record (in each stock.request), not at the analytical account level, so I can't extract it from there directly. Although what you mention could be done, I don't know if it is worthwhile and/or useful because I think this is not done in any other module.

You should know if the smart-button was used or not, but I would bet it was...

pedrobaeza · 2024-03-26T07:50:07Z

stock_request_analytic/models/stock_request_order.py

-class StockRequestOrder(models.Model):
-    _inherit = "stock.request.order"
-
-    analytic_count = fields.Integer(


pedrobaeza · 2024-03-26T07:50:26Z

stock_request_analytic/models/stock_request_order.py

-        readonly=True,
-        compute_sudo=True,
-    )
-    default_analytic_account_id = fields.Many2one(


A similar feature should be added

What functionality exactly? The analytical accounts are no longer "useful", analytical distribution (from stock.request) is now what matters. Do you want to add a default analytical distribution at stock.request.order level?

That the analytic distribution is filled with this default analytic account. Anyway, the same, check if it's used or not in our customers.

victoralmau · 2024-03-27T11:06:01Z

Finally I will not continue with this migration because I do not need this module, although anyone can continue with the work already done.

Some comments that I think may be useful:

Analytic account has been removed because now (v16) only the analytic distribution (stock_analytic) is used.
Analytic distribution has been added in stock.request to make it compatible with stock_analytic.
Analytic tags have been removed, now they are not in core and it would be necessary to create (after merging this PR) a new module stock_request_analytic_tag to add that functionality (probably it would also be necessary to create stock_analytic_tag).

github-actions · 2024-07-28T12:18:29Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

AaronHForgeFlow and others added 23 commits March 26, 2024 08:36

[ADD]stock_request_analytic

d8d0e93

[11.0] stock_request_analytic:

74819be

* clean views. * allow to create a stock.request with no analytic account. * remove copy attribute in non-stored field. * remove non-existing field from compute method.

[12.0][MIG] stock_request_analytic

1f88293

[IMP] Simplify inheritance of states

a6c9af5

[FIX] stock_request_*: add expected_date implicit on tests to avoid e…

6df1211

…rrors

[IMP] stock_request_analytic: add analytic tags to Stock Requests

4db8902

TT28488

[IMP] stock_request_analytic: black, isort, prettier

f8633f8

[MIG] stock_request_analytic: Migration to 13.0

1f7f848

Co-authored-by: Pimolnat Suntian <pimolnats@ecosoft.co.th> TT28896 [UPD] Update stock_request_analytic.pot [UPD] README.rst

[IMP] stock_request_analytic: black, isort, prettier

24d1b98

[14.0][MIG] stock_request_analytic

2515ff4

[14.0][IMP] stock_request_analytic: Add default analytic account on o…

4252711

…rders

[14.0][IMP] stock_request_analytic: Add analytic account to procureme…

ac6f49c

…nt values If procurement will trigger a purchase and not a move, there is no mean to transmit it (e.g.: to purchase). [UPD] Update stock_request_analytic.pot [UPD] README.rst stock_request_analytic 14.0.1.0.1

[FIX] Fix access right issues when using actions

404c191

stock_request_analytic 14.0.1.0.2

[FIX] Licensing issues

37f2173

[UPD] README.rst stock_request_analytic 14.0.1.0.3

[FIX] stock_request_analytic: Adding the correct groups to the views …

1097e25

…to avoid permissions errors [BOT] post-merge updates

[IMP] stock_request_analytic: pre-commit stuff

ab043bb

[MIG] stock_request_analytic: Migration to 16.0

a877399

Changes done: - Analytic_account_id field is removed from stock.request (and all related). - Added analytic_distribution field to stock.request. TT47865 Co-authored-by: Urvisha-OSI

victoralmau force-pushed the 16.0-mig-stock_request_analytic branch from 6367597 to a877399 Compare March 26, 2024 07:41

victoralmau mentioned this pull request Mar 26, 2024

[16.0][MIG] stock_request_analytic #3

Closed

OCA-git-bot added this to the 16.0 milestone Mar 26, 2024

pedrobaeza requested changes Mar 26, 2024

View reviewed changes

rousseldenis added the migration label Mar 26, 2024

rousseldenis added the needs review label Mar 26, 2024

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024

pedrobaeza closed this Jul 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] stock_request_analytic: Migration to 16.0 #16

[16.0][MIG] stock_request_analytic: Migration to 16.0 #16

victoralmau commented Mar 26, 2024 •

edited

Loading

pedrobaeza commented Mar 26, 2024

OCA-git-bot commented Mar 26, 2024

pedrobaeza left a comment •

edited

Loading

pedrobaeza Mar 26, 2024

victoralmau Mar 26, 2024

pedrobaeza Mar 26, 2024

pedrobaeza Mar 26, 2024

pedrobaeza Mar 26, 2024

victoralmau Mar 26, 2024

pedrobaeza Mar 26, 2024

victoralmau commented Mar 27, 2024

github-actions bot commented Jul 28, 2024

[16.0][MIG] stock_request_analytic: Migration to 16.0 #16

[16.0][MIG] stock_request_analytic: Migration to 16.0 #16

Conversation

victoralmau commented Mar 26, 2024 • edited Loading

pedrobaeza commented Mar 26, 2024

OCA-git-bot commented Mar 26, 2024

pedrobaeza left a comment • edited Loading

Choose a reason for hiding this comment

pedrobaeza Mar 26, 2024

Choose a reason for hiding this comment

victoralmau Mar 26, 2024

Choose a reason for hiding this comment

pedrobaeza Mar 26, 2024

Choose a reason for hiding this comment

pedrobaeza Mar 26, 2024

Choose a reason for hiding this comment

pedrobaeza Mar 26, 2024

Choose a reason for hiding this comment

victoralmau Mar 26, 2024

Choose a reason for hiding this comment

pedrobaeza Mar 26, 2024

Choose a reason for hiding this comment

victoralmau commented Mar 27, 2024

github-actions bot commented Jul 28, 2024

victoralmau commented Mar 26, 2024 •

edited

Loading

pedrobaeza left a comment •

edited

Loading