Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] stock_request_direction: Migration to 16.0 #20

Merged
merged 29 commits into from
Jun 11, 2024

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Apr 11, 2024

Module migrated to version 16.0

cc https://github.com/APSL 153667

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

max3903 and others added 28 commits April 11, 2024 14:36
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_direction/zh_CN/
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_direction/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_request_direction/
Since the location and routes depend on the warehouse that is selected on the stock request order, if the warehouse changes then so will the route options. This adds an on change event so if the warehouse changes, then the direction gets cleared and so do the routes on the product lines. This forces the user to properly reset the items using the correct routes for the newly selected warehouse.
The onchange method in the stock_request module is no longer needed so this overrides that to do nothing.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_request_direction/
Currently translated at 100.0% (8 of 8 strings)

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_request_direction/it/
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@celm1990 celm1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peluko00
Copy link
Contributor Author

Hi @max3903 , is this ready to merge?
I'm interested in to start migration to v17.

@max3903
Copy link
Member

max3903 commented May 17, 2024

/ocabot migration stock_request_direction

@max3903
Copy link
Member

max3903 commented May 17, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

There's no issue in this repo with the title 'Migration to version 16.0' and the milestone 16.0, so not possible to add the comment.

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-20-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 17, 2024
Signed-off-by max3903
@OCA-git-bot
Copy link
Contributor

@max3903 The merge process could not be finalized, because command twine check odoo_addon_stock_request_direction-16.0.1.0.0.1-py3-none-any.whl failed with output:

Checking odoo_addon_stock_request_direction-16.0.1.0.0.1-py3-none-any.whl: �[31mFAILED�[0m
�[31mERROR   �[0m `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line : Error: Anonymous hyperlink mismatch: 1 references but 0 targets.
         See "backrefs" attribute for IDs.                                      
�[33mWARNING �[0m `long_description_content_type` missing. defaulting to `text/x-rst`.   

@peluko00
Copy link
Contributor Author

@max3903 The merge process could not be finalized, because command twine check odoo_addon_stock_request_direction-16.0.1.0.0.1-py3-none-any.whl failed with output:

Checking odoo_addon_stock_request_direction-16.0.1.0.0.1-py3-none-any.whl: �[31mFAILED�[0m
�[31mERROR   �[0m `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line : Error: Anonymous hyperlink mismatch: 1 references but 0 targets.
         See "backrefs" attribute for IDs.                                      
�[33mWARNING �[0m `long_description_content_type` missing. defaulting to `text/x-rst`.   

@max3903 i have to do something or it's an error with oca addon?

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-20-by-LoisRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 11, 2024
Signed-off-by LoisRForgeFlow
@OCA-git-bot
Copy link
Contributor

@LoisRForgeFlow The merge process could not be finalized, because command twine check odoo_addon_stock_request_direction-16.0.1.0.0.1-py3-none-any.whl failed with output:

Checking odoo_addon_stock_request_direction-16.0.1.0.0.1-py3-none-any.whl: �[31mFAILED�[0m
�[31mERROR   �[0m `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line : Error: Anonymous hyperlink mismatch: 1 references but 0 targets.
         See "backrefs" attribute for IDs.                                      
�[33mWARNING �[0m `long_description_content_type` missing. defaulting to `text/x-rst`.   

@peluko00 peluko00 force-pushed the 16.0-mig-stock_request_direction branch from 41a0bb2 to 7e35760 Compare June 11, 2024 09:19
@peluko00
Copy link
Contributor Author

peluko00 commented Jun 11, 2024

/ocabot merge nobump

Can you relaunch again @LoisRForgeFlow please. I fixed the error

@LoisRForgeFlow
Copy link
Contributor

sure

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-20-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ee10c26 into OCA:16.0 Jun 11, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 478ed82. Thanks a lot for contributing to OCA. ❤️

@peluko00
Copy link
Contributor Author

sure

/ocabot merge nobump

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.