[16.0][MIG] stock_request_picking_type: Migration to 16.0 #21

peluko00 · 2024-04-11T13:35:28Z

Module migrated to version 16.0

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

[UPD] README.rst [UPD] Update stock_request_picking_type.pot [UPD] README.rst [UPD] Update stock_request_picking_type.pot

[UPD] Update stock_request_picking_type.pot [UPD] README.rst Added translation using Weblate (Chinese (Simplified)) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (28 of 28 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_picking_type Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_picking_type/zh_CN/ Added translation using Weblate (Spanish) Translated using Weblate (Spanish) Currently translated at 100.0% (28 of 28 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_picking_type Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_picking_type/es/

[UPD] README.rst [UPD] Update stock_request_picking_type.pot [UPD] README.rst [UPD] Update stock_request_picking_type.pot

[UPD] Update stock_request_picking_type.pot [UPD] README.rst Added translation using Weblate (Chinese (Simplified)) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (28 of 28 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_picking_type Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_picking_type/zh_CN/ Added translation using Weblate (Spanish) Translated using Weblate (Spanish) Currently translated at 100.0% (28 of 28 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_picking_type Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_picking_type/es/ Added translation using Weblate (Portuguese (Brazil)) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (28 of 28 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_picking_type Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_picking_type/pt_BR/

[IMP] User write()

[IMP] Flake8

To appear in OCA shop in the good category.

[UPD] Update stock_request_picking_type.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_request_picking_type Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_request_picking_type/

…ny editabe tree on sro request model

OCA-git-bot · 2024-05-08T08:28:06Z

There's no issue in this repo with the title 'Migration to version 16.0' and the milestone 16.0, so not possible to add the comment.

rousseldenis · 2024-05-08T08:29:19Z

stock_request_picking_type/tests/test_stock_request.py

                }
            )
        )

-    def _create_product(self, default_code, name, company_id, **vals):


Don't remove those kind of helper methods.

rousseldenis · 2024-05-08T08:30:17Z

stock_request_picking_type/tests/test_stock_picking_type.py

@@ -74,39 +90,11 @@ def setUpClass(cls):
            "stock.no_auto_scheduler", "True"
        )

-    def _create_user(self, name, group_ids, company_ids):


Don't remove those helper methods.

peluko00 · 2024-05-08T09:09:07Z

Fix it! Can review again please @rousseldenis

lbarry-apsl

Reviewed

rousseldenis · 2024-05-15T14:20:09Z

stock_request_picking_type/tests/test_stock_request.py

-            self.env["res.users"]
-            .with_context({"no_reset_password": True})
+            cls.env["res.users"]
+            .with_context(**{"no_reset_password": True})


You can avoid such writing by using arguments directly:
.with_context(no_reset_password=True)

rousseldenis · 2024-05-15T14:20:37Z

stock_request_picking_type/tests/test_stock_request.py

@@ -185,4 +190,4 @@ def test_create(self):
        order = self.request_order.with_user(self.stock_request_user).create(order_vals)

        # test create()
-        self.assertEqual(order.picking_type_id, new_pick_type)
+        self.assertNotEqual(order.picking_type_id, new_pick_type)


Why is this changed ?

I remove the test because is not impacts in the total coverage at the module and now is not possible to modify the warehouse and location after creation in form.

celm1990

LGTM tested functionally

rousseldenis

Code review

rousseldenis · 2024-05-16T06:07:10Z

stock_request_picking_type/models/stock_request_order.py

+    picking_type_id = fields.Many2one(
+        comodel_name="stock.picking.type",
+        string="Operation Type",
+        default=_get_default_picking_type,


This deserves a lambda function instead.

Update: No more default if changed to compute.

rousseldenis · 2024-05-16T06:08:11Z

stock_request_picking_type/models/stock_request_order.py

+
+    @api.model
+    def _get_default_picking_type(self):
+        companies = self._context.get("allowed_company_ids", []).copy()


_context is deprecated since a long time: https://github.com/odoo/odoo/blob/16.0/odoo/models.py#L5160

Still using here:
https://github.com/odoo/odoo/blob/17.0/odoo/models.py#L1158

That's not why they are using it, we should do it too 🙈

With self.env.context much better no?

Yes that's the one

rousseldenis · 2024-05-16T06:23:55Z

stock_request_picking_type/models/stock_request_order.py

+                [
+                    ("code", "=", "stock_request_order"),
+                    "|",
+                    ("warehouse_id.company_id", "in", companies),


Moreover, I think this is not necessary as there is a record rule on picking type. I'm wondering why it is not sufficent to search on...

rousseldenis · 2024-05-16T06:24:57Z

stock_request_picking_type/models/stock_request_order.py

+    )
+
+    @api.onchange("warehouse_id")
+    def onchange_warehouse_picking_id(self):


This should now be avoided. You can change the picking_type_id field to a computed/stored/readonly=False field instead and change this to _compute method.

rousseldenis · 2024-05-16T06:25:40Z

stock_request_picking_type/models/stock_request_order.py

+                self._origin.write({"picking_type_id": picking_type_id.id})
+
+    @api.model
+    def create(self, vals):


This can be avoided too referring the remark above.

create() override should be removed.

But the field is required

The compute will do the job as its aim is to get a default value.

The compute is not the same as default because on create can't assign a value

Use precompute=True

peluko00 · 2024-05-16T09:11:29Z

All improvements done @rousseldenis

rousseldenis · 2024-05-16T09:17:33Z

stock_request_picking_type/models/stock_request_order.py

        required=True,
+        store=True,


You should add readonly=False too.

peluko00 · 2024-05-22T09:33:15Z

It's ready for merge @rousseldenis ?

peluko00 · 2024-06-13T10:26:53Z

Any update @rousseldenis ? I need that for merge that module

OCA-git-bot · 2024-06-13T14:18:14Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2024-06-13T14:20:29Z

/ocabot merge nobump

OCA-git-bot · 2024-06-13T14:20:42Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-21-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot · 2024-06-13T14:27:15Z

Congratulations, your PR was merged at da59a7d. Thanks a lot for contributing to OCA. ❤️

max3903 and others added 30 commits April 11, 2024 15:32

[ADD] stock_request_picking_type (#590)

eb39efa

[UPD] README.rst [UPD] Update stock_request_picking_type.pot [UPD] README.rst [UPD] Update stock_request_picking_type.pot

[IMP] stock_request_picking_type: Use Submitted state

4a4ec07

[IMP] Bump version

d7f0f1d

[FIX] stock_request_picking_type

ac4fc8a

[REN] stock_request_picking_type: migration script

f13b5e3

[IMP] stock_request_picking_type: black, isort

4a8e8d3

[MIG] stock_request_picking_type: Migration to 13.0

ebdd4a1

Revert "[13.0][MIG] stock_request_picking_type"

db8ccfa

[ADD] stock_request_picking_type (#590)

5458acd

[UPD] README.rst [UPD] Update stock_request_picking_type.pot [UPD] README.rst [UPD] Update stock_request_picking_type.pot

[IMP] stock_request_picking_type: Use Submitted state

da4cff3

[IMP] Bump version

753edae

[FIX] stock_request_picking_type

f150e24

[REN] stock_request_picking_type: migration script

698685c

[IMP] Synchronize Picking Type and Warehouse

2bc1aae

[IMP] User write()

stock_request_picking_type 12.0.2.1.0

61a8822

[IMP] Set Picking Type in Create

eb1a12e

[IMP] Flake8

stock_request_picking_type 12.0.2.1.1

175bad0

[IMP] category: 'Warehouse Management' -> 'Warehouse'

320b33b

To appear in OCA shop in the good category.

[IMP] stock_request_picking_type: black, isort, prettier

e9aa262

[IMP] stock_request_picking_type: black, isort, prettier

0b53635

[MIG] stock_request_picking_type: Migration to 14.0

cd7470c

[UPD] Update stock_request_picking_type.pot

d64201a

[UPD] README.rst

f1119ff

[FIX]stock_request_direction: fixed an error while on click on one2ma…

93ce1c9

…ny editabe tree on sro request model

[FIX] stock_request_picking_type: ValueError: malformed node or string

5c82e45

Apply suggestions from code review

35bc04c

stock_request_picking_type 14.0.1.1.0

719c4a2

rousseldenis requested changes May 8, 2024

View reviewed changes

peluko00 force-pushed the 16.0-mig-stock_request_picking_type branch from cc31dd5 to eee1a16 Compare May 8, 2024 09:08

lbarry-apsl approved these changes May 8, 2024

View reviewed changes

peluko00 mentioned this pull request May 15, 2024

[16.0][MIG] stock request picking type #4

Closed

rousseldenis reviewed May 15, 2024

View reviewed changes

peluko00 force-pushed the 16.0-mig-stock_request_picking_type branch from eee1a16 to 50b061b Compare May 15, 2024 15:40

celm1990 approved these changes May 15, 2024

View reviewed changes

rousseldenis requested changes May 16, 2024

View reviewed changes

peluko00 force-pushed the 16.0-mig-stock_request_picking_type branch 2 times, most recently from 5ba5b3c to 05cc872 Compare May 16, 2024 09:10

rousseldenis reviewed May 16, 2024

View reviewed changes

[MIG] stock_request_picking_type: Migration to 16.0

6fc78fe

peluko00 force-pushed the 16.0-mig-stock_request_picking_type branch from 05cc872 to 6fc78fe Compare May 16, 2024 09:57

rousseldenis approved these changes Jun 13, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 13, 2024

OCA-git-bot added the bot is merging ⏳ label Jun 13, 2024

OCA-git-bot merged commit 192e2f7 into OCA:16.0 Jun 13, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 13, 2024

[16.0][MIG] stock_request_picking_type: Migration to 16.0 #21

[16.0][MIG] stock_request_picking_type: Migration to 16.0 #21

Conversation

peluko00 commented Apr 11, 2024 • edited Loading

OCA-git-bot commented May 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peluko00 commented May 8, 2024

lbarry-apsl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peluko00 May 15, 2024 • edited Loading

Choose a reason for hiding this comment

celm1990 left a comment

Choose a reason for hiding this comment

rousseldenis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peluko00 commented May 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peluko00 commented May 22, 2024

peluko00 commented Jun 13, 2024 • edited Loading

OCA-git-bot commented Jun 13, 2024

rousseldenis commented Jun 13, 2024

OCA-git-bot commented Jun 13, 2024

OCA-git-bot commented Jun 13, 2024

peluko00 commented Apr 11, 2024 •

edited

Loading

peluko00 May 15, 2024 •

edited

Loading

peluko00 commented Jun 13, 2024 •

edited

Loading