Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_request_direction: Migration to 17.0 #33

Merged
merged 33 commits into from
Jun 13, 2024

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Jun 11, 2024

Module migrated to version 17.0

cc https://github.com/APSL 156412
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

max3903 and others added 30 commits June 11, 2024 16:15
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_direction/zh_CN/
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_direction/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_request_direction/
Since the location and routes depend on the warehouse that is selected on the stock request order, if the warehouse changes then so will the route options. This adds an on change event so if the warehouse changes, then the direction gets cleared and so do the routes on the product lines. This forces the user to properly reset the items using the correct routes for the newly selected warehouse.
The onchange method in the stock_request module is no longer needed so this overrides that to do nothing.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_request_direction/
Currently translated at 100.0% (8 of 8 strings)

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_request_direction/it/
weblate and others added 2 commits June 11, 2024 16:15
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-request-16.0/stock-logistics-request-16.0-stock_request_direction
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-request-16-0/stock-logistics-request-16-0-stock_request_direction/
@peluko00 peluko00 mentioned this pull request Jun 11, 2024
8 tasks
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good, checked in runboat

Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in Runbot. LGTM

@peluko00
Copy link
Contributor Author

Ready for merge @max3903 ?

@max3903
Copy link
Member

max3903 commented Jun 13, 2024

/ocabot migration stock_request_direction

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 13, 2024
@max3903
Copy link
Member

max3903 commented Jun 13, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-33-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2f47f6d into OCA:17.0 Jun 13, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 45ed18f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.