[17.0][MIG] stock_request_purchase: Migration to 17.0 #35

ced-adhoc · 2024-07-10T12:35:08Z

No description provided.

pedrobaeza · 2024-07-16T07:27:46Z

/ocabot migration stock_request_purchase

florenciafrigieri2

Functional review ok. The PO is correctly linked to the stock request and stock request order.

florenciafrigieri2 · 2024-07-22T13:23:10Z

@pedrobaeza Hi Pedro, can you review this module in order to merge it? Thanks in advance!

pedrobaeza · 2024-07-22T13:27:56Z

/ocabot migration stock_request_purchase

Sorry, another reviewer should check this PR before merging.

pedrobaeza · 2024-07-22T13:28:22Z

stock_request_purchase/tests/test_stock_request_purchase.py

-        cls.route_buy = cls.warehouse.buy_pull_id.route_id
-        cls.supplier = cls.env["res.partner"].create({"name": "Supplier"})
-        cls.product.write(
+    def setUp(self):


This change is not correct. Please revert it.

Hello @pedrobaeza,
I've reverted the change as requested. The original setup used setUpClass(cls), which caused an AttributeError because cls.warehouse wasn't initialized properly. To address this, I changed it to setUp(self), ensuring the superclass's setUp method was called to initialize the attributes.
As I'm new to Odoo development, could you please advise me on the correct way to initialize these attributes in setUpClass without causing errors?
Thank you for your help.

OK, I see. The problem is that the original test is also with setUp:

https://github.com/OCA/stock-logistics-request/blob/17.0/stock_request/tests/test_stock_request.py#L13

which is not correct at all, as it's not making use of this method that avoids to execute the setup for each of the test methods, running only once instead of N times.

Can you please make a new PR changing the test of stock_request to setUpClass?

Can you please make a new PR changing the test of stock_request to setUpClass?

Agree. I would say in addition of this, moving the setupClass to a common.py is a best practice too.

Hi @pedrobaeza
I noticed that the changes requested for the stock_request module tests in v17 are already done in v16:
https://github.com/OCA/stock-logistics-request/blob/16.0/stock_request/tests/test_stock_request.py
But they are missing in v17:
https://github.com/OCA/stock-logistics-request/blob/17.0/stock_request/tests/test_stock_request.py

Could you please confirm if the changes you want me to make are the same as those made in v16? If so, do you know why these changes are not in v17?

Additionally, should I create a separate PR for the modifications in stock_request, or should I include these changes in another commit within this existing PR I have for migrating stock_request_purchase?

Thanks!

Yes, that's it. You can do it as a separate commit, but inside this PR, as it's an adjustment linked to this migration.

Hi @pedrobaeza , all done.
Could you please review it?
Thanks

alan196

Functional Review LGTM 👍

OCA-git-bot · 2024-07-22T17:14:58Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA Transbot updated translations from Transifex

- Error with the sequence number. - Visible texts that should be in uppercases. - order_id should only be visible if group_stock_request_order option is enabled. - adds more tests - adds consistency between models company-wise

[UPD] Update stock_request_purchase.pot

Currently translated at 100,0% (13 of 13 strings) Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_request_purchase Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_request_purchase/es/

[UPD] Update stock_request_purchase.pot [UPD] README.rst

Currently translated at 100.0% (13 of 13 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_purchase Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_purchase/es/

[UPD] Update stock_request_purchase.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_request_purchase Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_request_purchase/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_request_purchase Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_request_purchase/

[UPD] Update stock_request_purchase.pot

[UPD] Update stock_request_purchase.pot [UPD] README.rst stock_request_purchase 15.0.1.0.1

…urchases TT43414 stock_request_purchase 15.0.1.0.2

…w_stock_request action of purchase.order TT43297

… all stock requests from action. Allows inheritance by other modules TT43297 stock_request_purchase 15.0.1.1.0 [UPD] README.rst

TT44811 stock_request_purchase 15.0.1.2.0 [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_request_purchase Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_request_purchase/

Currently translated at 100.0% (13 of 13 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_request_purchase Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_request_purchase/es/

Translated using Weblate (Italian) Currently translated at 100.0% (13 of 13 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_request_purchase Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_request_purchase/it/

Co-authored-by: Bruno-Zanotti

pedrobaeza

Great, thanks

/ocabot merge nobump

ced-adhoc · 2024-08-05T19:23:55Z

@pedrobaeza could you please merge it?

pedrobaeza · 2024-08-05T20:06:53Z

/ocabot merge nobump

OCA-git-bot · 2024-08-05T20:07:00Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-35-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-08-05T20:12:43Z

Congratulations, your PR was merged at 911a66e. Thanks a lot for contributing to OCA. ❤️

ced-adhoc force-pushed the 17.0-mig-stock_request_purchase branch 5 times, most recently from 32f3c95 to 747c1f8 Compare July 15, 2024 18:47

OCA-git-bot added this to the 17.0 milestone Jul 16, 2024

OCA-git-bot mentioned this pull request Jul 16, 2024

Migration to version 17.0 #10

Open

8 tasks

ced-adhoc force-pushed the 17.0-mig-stock_request_purchase branch from 747c1f8 to 5fcdbca Compare July 16, 2024 18:31

florenciafrigieri2 approved these changes Jul 22, 2024

View reviewed changes

pedrobaeza reviewed Jul 22, 2024

View reviewed changes

alan196 approved these changes Jul 22, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 22, 2024

ced-adhoc force-pushed the 17.0-mig-stock_request_purchase branch from 5fcdbca to 6361791 Compare July 22, 2024 18:14

ced-adhoc force-pushed the 17.0-mig-stock_request_purchase branch 3 times, most recently from 5408a69 to 03470c6 Compare July 31, 2024 19:42

oca-transbot and others added 9 commits August 1, 2024 16:14

OCA Transbot updated translations from Transifex

f58bb52

add stock_request in 11.0

c35c29e

OCA Transbot updated translations from Transifex

[IMP] stock_request_purchase: Remove hook

de18c34

[IMP] stock_request_purchase: Add Stock request orders. Change logo

c022e44

[FIX] Various fixes:

8ac9e19

- Error with the sequence number. - Visible texts that should be in uppercases. - order_id should only be visible if group_stock_request_order option is enabled. - adds more tests - adds consistency between models company-wise

various fixes

6699d5b

[IMP] simplify queries

4c89654

[UPD] Update stock_request_purchase.pot

[12.0][MIG] stock_request_purchase

40cda91

[UPD] Update stock_request_purchase.pot [UPD] README.rst

Nelson Ramírez Sánchez and others added 20 commits August 1, 2024 16:14

[IMP] stock_request_purchase: black, isort

5b1adc7

[UPD] Eficent -> ForgeFlow

b59b641

[IMP] stock_request_purchase: black, isort, prettier

e37cca1

[MIG] stock_request_purchase: Migration to 14.0

8442598

[14.0][IMP] stock_request_purchase: Use _for_xml_id for actions

23e38a6

[UPD] Update stock_request_purchase.pot

[MIG] stock_request_purchase: Migration to 15.0

128b368

[UPD] Update stock_request_purchase.pot [UPD] README.rst stock_request_purchase 15.0.1.0.1

[IMP] stock_request_purchase: Propagate the cancellation of related p…

14712f3

…urchases TT43414 stock_request_purchase 15.0.1.0.2

[IMP] stock_request_purchase: Change invisible attr of the action_vie…

8810653

…w_stock_request action of purchase.order TT43297

[IMP] stock_request_purchase: Add _get_stock_requests() method to get…

b8bf7d1

… all stock requests from action. Allows inheritance by other modules TT43297 stock_request_purchase 15.0.1.1.0 [UPD] README.rst

[IMP] stock_request_purchase: pre-commit stuff

3b01127

[MIG] stock_request_purchase: Migration to 16.0

2b8684b

Co-authored-by: Bruno-Zanotti

[UPD] Update stock_request_purchase.pot

0ced3c0

[IMP] stock_request_purchase: pre-commit execution

33d60d8

[17.0][MIG] stock_request_purchase: Migration to 17.0

f90147d

[17.0][FIX] stock_request: setUp() to setUpClass()

5244df8

ced-adhoc force-pushed the 17.0-mig-stock_request_purchase branch from 03470c6 to 5244df8 Compare August 1, 2024 19:29

pedrobaeza approved these changes Aug 1, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Aug 5, 2024

OCA-git-bot merged commit b1b25da into OCA:17.0 Aug 5, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] stock_request_purchase: Migration to 17.0 #35

[17.0][MIG] stock_request_purchase: Migration to 17.0 #35

ced-adhoc commented Jul 10, 2024

pedrobaeza commented Jul 16, 2024

florenciafrigieri2 left a comment

florenciafrigieri2 commented Jul 22, 2024

pedrobaeza commented Jul 22, 2024

pedrobaeza Jul 22, 2024

ced-adhoc Jul 22, 2024

pedrobaeza Jul 23, 2024

rousseldenis Jul 23, 2024

ced-adhoc Jul 30, 2024

pedrobaeza Jul 31, 2024

ced-adhoc Aug 1, 2024

alan196 left a comment

OCA-git-bot commented Jul 22, 2024

pedrobaeza left a comment

ced-adhoc commented Aug 5, 2024

pedrobaeza commented Aug 5, 2024

OCA-git-bot commented Aug 5, 2024

OCA-git-bot commented Aug 5, 2024

[17.0][MIG] stock_request_purchase: Migration to 17.0 #35

[17.0][MIG] stock_request_purchase: Migration to 17.0 #35

Conversation

ced-adhoc commented Jul 10, 2024

pedrobaeza commented Jul 16, 2024

florenciafrigieri2 left a comment

Choose a reason for hiding this comment

florenciafrigieri2 commented Jul 22, 2024

pedrobaeza commented Jul 22, 2024

pedrobaeza Jul 22, 2024

Choose a reason for hiding this comment

ced-adhoc Jul 22, 2024

Choose a reason for hiding this comment

pedrobaeza Jul 23, 2024

Choose a reason for hiding this comment

rousseldenis Jul 23, 2024

Choose a reason for hiding this comment

ced-adhoc Jul 30, 2024

Choose a reason for hiding this comment

pedrobaeza Jul 31, 2024

Choose a reason for hiding this comment

ced-adhoc Aug 1, 2024

Choose a reason for hiding this comment

alan196 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jul 22, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

ced-adhoc commented Aug 5, 2024

pedrobaeza commented Aug 5, 2024

OCA-git-bot commented Aug 5, 2024

OCA-git-bot commented Aug 5, 2024