[18.0][MIG] stock_reserve: Migration to 18.0.

[rjaraspearhead]

Extract from OCA/stock-logistics-warehouse#2270

[jbaudoux]

LG, not tested

[jbaudoux]

Out of curiosity, what is your usage of this module?

[rjaraspearhead]

@jbaudoux
The stock_reserve module is used to partially or fully reserve inventory, ensuring that the reserved quantity is not available for other operations.

Additionally, this module serves as a foundation for other extensions, such as stock_reserve_sale, which allows reservations to be created directly from the sales order without the need to confirm it.

[jbaudoux]

@jbaudoux The stock_reserve module is used to partially or fully reserve inventory, ensuring that the reserved quantity is not available for other operations.

Additionally, this module serves as a foundation for other extensions, such as stock_reserve_sale, which allows reservations to be created directly from the sales order without the need to confirm it.

I was wondering if you were doing reservations outside sales.

For sales reservation, there is https://github.com/OCA/sale-workflow/pulls?q=is%3Apr+is%3Aopen+prebook since 14.0 which is better in my opinion. PRs are being moved to https://github.com/OCA/sale-prebook

[jbaudoux]

/ocabot migration stock_reserve

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[ivs-cetmix]

Hi @rjaraspearhead , thank you for your contribution!
Could you please rebase the PR?

[ivs-cetmix]

/ocabot rebase

[OCA-git-bot]

Sorry @ivs-cetmix you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[rjaraspearhead]

Hi @rjaraspearhead , thank you for your contribution! Could you please rebase the PR?

Done

[zalei-odoo]

I checked the functionality of the module.
The reservation of the product is expected if the product is less than the available quantity. It's all good.
In my opinion, the wrong behavior concerns a situation when a quantity of goods is reserved more than is available.
In this case, the Stork Reservations smart button displays a quantity of 0 instead of the specified quantity, although in the Forecasted smart button the quantity is minus.,
The action on the button also filters the result and does not show the reserve, because the default filter is set to filter the Partially Available status.

[ivs-cetmix]

@zalei-odoo thank you for your feedback! Could you please approve the PR or request changes if needed?

[zalei-odoo]

I don't have enough rights.
Can I get access rights or ask someone to approve the PR

curl -s -H "Authorization: token <MY_TOKEN>" \
     https://api.github.com/repos/OCA/stock-logistics-reservation \
| jq '.permissions'
{
  "admin": false,
  "maintain": false,
  "push": false,
  "triage": false,
  "pull": true
}

[ivs-cetmix]

@zalei-odoo looks weird, don't you have this menu?

[zalei-odoo]

Thank you, Ivan, I haven't done this before, I really have it. I'll do it now)

[zalei-odoo]

The module's functionality is functional enough for typical applications when working with products and warehouses. I checked the reservation (when the quantity for reservation is less than the available quantity) and the cron task "Release the stock reservation having a passed validity date".

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.