Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] stock_secondary_unit #1701

Closed
wants to merge 24 commits into from

Conversation

remihb
Copy link

@remihb remihb commented Apr 26, 2023

With changes introduced by #1606 for 15.0 (Compatibility with product variants)

Wait for OCA/product-attribute#1325 to be merged

sergio-teruel and others added 22 commits April 26, 2023 14:13
Currently translated at 100.0% (15 of 15 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_secondary_unit
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_secondary_unit/zh_CN/
Currently translated at 100.0% (15 of 15 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_secondary_unit
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_secondary_unit/zh_CN/
On move line creation, the precision of secondary qty rounding is wrong; the unit of measure factor is being used instead of rounding.
…variants view on common form. Create related template secondary unit field.

TT27057
[IMP] stock_secondary_unit: Use product_secondary_unit mixin model from product-attribute repository.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_secondary_unit
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_secondary_unit/
@remihb remihb force-pushed the 16.0-mig-stock_secondary_unit branch from 825da2a to c7a3fbf Compare April 27, 2023 00:03
@rousseldenis
Copy link
Contributor

/ocabot migration stock_secondary_unit

@rousseldenis
Copy link
Contributor

@remihb Thanks for this. FYI, you can embed open depending PR's here following this method:

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

This can help reviewers to test on runboat and unit tests running.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 27, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 27, 2023
69 tasks
@remihb remihb force-pushed the 16.0-mig-stock_secondary_unit branch from c7a3fbf to a0b3295 Compare April 27, 2023 13:12
@remihb remihb force-pushed the 16.0-mig-stock_secondary_unit branch from 6f081e2 to 3d7b2c7 Compare April 28, 2023 14:13
@remihb
Copy link
Author

remihb commented Apr 28, 2023

@remihb Thanks for this. FYI, you can embed open depending PR's here following this method:

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

This can help reviewers to test on runboat and unit tests running.

I follow the instructions in the link you gave me. But when I put the test-requirements.txt at the root folder of the OCA repo (as mentioned in instructions), it raise me the error Unreleased dependencies found in "test-requirements.txt during the tests / Detect unreleased dependencies

So I tried to put the test-requirements.txt at the module folder level so the tests / Detect unreleased dependencies is successful but the tests / test part is not.

I don't know what to do about it. Can you help me ?

@matiasperalta1
Copy link

@remihb Hi! could you rebase this PR to get the runboat build? The dependence OCA/product-attribute#1325 has been merged

@rousseldenis
Copy link
Contributor

@remihb Thanks for this. FYI, you can embed open depending PR's here following this method:
https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29
This can help reviewers to test on runboat and unit tests running.

I follow the instructions in the link you gave me. But when I put the test-requirements.txt at the root folder of the OCA repo (as mentioned in instructions), it raise me the error Unreleased dependencies found in "test-requirements.txt during the tests / Detect unreleased dependencies

So I tried to put the test-requirements.txt at the module folder level so the tests / Detect unreleased dependencies is successful but the tests / test part is not.

I don't know what to do about it. Can you help me ?

@remihb That's normal. In order to not forget to remove the added lines in test-requirements.txt before merging, a failed test has been added. When all dependencies are merged, PR author is invited to remove those lines.

@rousseldenis
Copy link
Contributor

@remihb Do you mind if we switch to #1769 ?

@pedrobaeza
Copy link
Member

Superseded by #1769

@pedrobaeza pedrobaeza closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.