[ADD][14.0] procurement_auto_create_group_by_product #1821

jbaudoux · 2023-08-24T17:12:26Z

Pick by product by generating one picking per product on the procurement run.
Configurable on the rule.
A procurement group per product will be generated.

I refactored a bit procurement_create_group to make it hookable

The use case it to be able a pick by product instead of by SO. So if 5 SO are for the same product, you have only one move for the total quantity.

Initially we had configured one fixed procurement group on the rule and all moves where added to the same picking. Users where working on the move lines. This was causing performance issue each time a new move was inserted as there are lot of moves and odoo recomputes the check_entire_pack on all moves which is slow. This was also causing concurrent updates when 2 users working on different products were extracting & validating a move line from that same picking.
With this new module, we greatly increase the amount of pickings but we reduce a lot the recomputation when a new move is added as there should be only one move in the picking, and we reduce to the minimum the risk of concurrent updates (it remains only if 2 users work on the same product on 2 different locations).

cc @mt-software-de @LoisRForgeFlow @BernatPForgeFlow

sebalix · 2023-08-28T13:40:46Z

procurement_auto_create_group/models/procurement_group.py

@@ -13,13 +13,6 @@ def _get_rule(self, product_id, location_id, values):
        rule = super()._get_rule(product_id, location_id, values)
        # If there isn't a date planned in the values it means that this
        # method has been called outside of a procurement process.
-        if (
-            rule
-            and not values.get("group_id")


Are you sure we want to remove this check? This could have side-effects on existing installations no?

Following your commit message it's what you want, but just to be sure about the possible regressions.

I could not find out why it was there. I hope it is safe to remove it @LoisRForgeFlow @JordiBForgeFlow
Otherwise it prevents the feature to work in a pull flow coming from a SO.

Indeed, this is a bit risky. From our side, we have reviewed and we shouldn't be affected by the change as we never use it for SO rules. However, there might be other installations in which this can lead to a change in the behavior.

My 2 cents.

Just in case, I think you can reduce the risk by putting the if condition in a method and doing super in the new module, removing the condition that is not wanted.

If you don't see a breaking change, let's consider it a bug fix.
Note that I'm not changing anything in regards of the above comment regarding date planned.

The configuration of the rule should prevail. If it is configured to create a new procurement group, then it should do it. Independently of how the rule is run.

procurement_auto_create_group/models/stock_rule.py

procurement_auto_create_group_by_product/models/stock_rule.py

sebalix · 2023-10-09T08:23:21Z

@jbaudoux pre-commit to fix

Do not override rule1 during setup, renamed the 2 rules.

Regroup the creation of the procurement group in a method.

When the pull flow is coming from an SO, a procurement group is already preset. When the option to auto create a procurement group, replace that procurement group by a new one.

jbaudoux · 2023-10-09T20:48:32Z

rebased

Allow to merge moves having different date_deadline to pick everything in one operation

jbaudoux · 2023-10-10T08:06:02Z

ping @mt-software-de for review

jbaudoux · 2023-11-28T10:52:08Z

@mt-software-de @sebalix @TDu Need review

mt-software-de

Minor remarks, to ensure only one group per product.

mt-software-de · 2023-11-28T11:10:29Z

procurement_auto_create_group_by_product/models/procurement_group.py

+class ProcurementGroup(models.Model):
+    _inherit = "procurement.group"
+
+    product_id = fields.Many2one("product.product", index=True)


Do we need a constraint? To ensure that there is only one group per product?

mt-software-de · 2023-11-28T11:14:28Z

procurement_auto_create_group_by_product/models/stock_rule.py

+            if product.auto_create_procurement_group_ids:
+                return fields.first(product.auto_create_procurement_group_ids)


Maybe we should add a lock, to ensure there is only one group created in case of auto_by_product?

Suggested change

if product.auto_create_procurement_group_ids:

return fields.first(product.auto_create_procurement_group_ids)

if product.auto_create_procurement_group_ids:

return fields.first(product.auto_create_procurement_group_ids)

else:

# lock to ensure there is only one group created

@jbaudoux could you merge jbaudoux#1 ?

Concurent transaction could create multiple procurement group for the same product. The use of an adivsory lock will prevent this from happening.

…-add-lock [IMP] proc_auto_create_grp_by_product: add lock

jbaudoux · 2024-04-05T15:47:53Z

@mt-software-de I have done this improvement 3213a30

mt-software-de

LGTM

OCA-git-bot · 2024-04-09T13:32:54Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Raise correct error to allow correct catching and retry

jbaudoux · 2024-05-22T09:20:48Z

/ocabot merge minor

OCA-git-bot · 2024-05-22T09:21:55Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1821-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot · 2024-05-22T09:38:28Z

Congratulations, your PR was merged at cd9cf3b. Thanks a lot for contributing to OCA. ❤️

jbaudoux force-pushed the 14-procurement_create_group_by_product branch 7 times, most recently from f39cd29 to 6f9c4f0 Compare August 28, 2023 12:23

jbaudoux marked this pull request as ready for review August 28, 2023 12:24

jbaudoux force-pushed the 14-procurement_create_group_by_product branch from 6f9c4f0 to e19156a Compare August 28, 2023 12:26

jbaudoux mentioned this pull request Aug 28, 2023

[MOD] procurement_auto_create_group_carrier OCA/stock-logistics-workflow#1368

Closed

sebalix reviewed Aug 28, 2023

View reviewed changes

jbaudoux force-pushed the 14-procurement_create_group_by_product branch 2 times, most recently from 11e7cc7 to d99d052 Compare September 1, 2023 17:16

jbaudoux added 4 commits October 9, 2023 22:46

[FIX] procurement_auto_create_group: test setup

f83d9f4

Do not override rule1 during setup, renamed the 2 rules.

[IMP] procurement_auto_create_group

8eea9d1

Regroup the creation of the procurement group in a method.

[IMP] procurement_auto_create_group: pull flow

cacd601

When the pull flow is coming from an SO, a procurement group is already preset. When the option to auto create a procurement group, replace that procurement group by a new one.

[ADD] procurement_auto_create_group_by_product

775c126

jbaudoux force-pushed the 14-procurement_create_group_by_product branch from d99d052 to 41de956 Compare October 9, 2023 20:47

jbaudoux force-pushed the 14-procurement_create_group_by_product branch from 41de956 to d2cec54 Compare October 9, 2023 20:56

[IMP] proc_auto_create_grp_by_product: merge moves

252b9ad

Allow to merge moves having different date_deadline to pick everything in one operation

jbaudoux force-pushed the 14-procurement_create_group_by_product branch from d2cec54 to 252b9ad Compare October 9, 2023 21:44

rousseldenis added the needs review label Nov 6, 2023

rousseldenis added this to the 14.0 milestone Nov 6, 2023

mt-software-de approved these changes Nov 28, 2023

View reviewed changes

proc_auto_create_grp_by_product: fix concurrent group creation

586609f

Concurent transaction could create multiple procurement group for the same product. The use of an adivsory lock will prevent this from happening.

sebalix approved these changes Mar 25, 2024

View reviewed changes

OCA-git-bot added the approved label Mar 25, 2024

Merge pull request #1 from TDu/14-procurement_create_group_by_product…

6cdd79b

…-add-lock [IMP] proc_auto_create_grp_by_product: add lock

jbaudoux force-pushed the 14-procurement_create_group_by_product branch 6 times, most recently from 40e94f2 to c831049 Compare April 8, 2024 08:46

mt-software-de approved these changes Apr 9, 2024

View reviewed changes

OCA-git-bot added the ready to merge label Apr 9, 2024

proc_auto_create_grp_by_product: fix raised error

6572251

Raise correct error to allow correct catching and retry

jbaudoux force-pushed the 14-procurement_create_group_by_product branch from c920921 to 6572251 Compare May 8, 2024 09:38

OCA-git-bot added the bot is merging ⏳ label May 22, 2024

OCA-git-bot merged commit c521e0b into OCA:14.0 May 22, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 22, 2024

sebalix mentioned this pull request Sep 18, 2024

[16.0][FW] procurement_auto_create_group: partial ports of #1821 #2157

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][14.0] procurement_auto_create_group_by_product #1821

[ADD][14.0] procurement_auto_create_group_by_product #1821

jbaudoux commented Aug 24, 2023 •

edited

Loading

sebalix Aug 28, 2023

sebalix Aug 28, 2023

jbaudoux Aug 28, 2023

LoisRForgeFlow Dec 12, 2023 •

edited

Loading

AaronHForgeFlow Dec 12, 2023

jbaudoux Dec 12, 2023

sebalix commented Oct 9, 2023

jbaudoux commented Oct 9, 2023

jbaudoux commented Oct 10, 2023

jbaudoux commented Nov 28, 2023

mt-software-de left a comment

mt-software-de Nov 28, 2023 •

edited

Loading

mt-software-de Nov 28, 2023

mt-software-de Jan 15, 2024

jbaudoux commented Apr 5, 2024 •

edited

Loading

mt-software-de left a comment

OCA-git-bot commented Apr 9, 2024

jbaudoux commented May 22, 2024

OCA-git-bot commented May 22, 2024

OCA-git-bot commented May 22, 2024

		if product.auto_create_procurement_group_ids:
		return fields.first(product.auto_create_procurement_group_ids)

[ADD][14.0] procurement_auto_create_group_by_product #1821

[ADD][14.0] procurement_auto_create_group_by_product #1821

Conversation

jbaudoux commented Aug 24, 2023 • edited Loading

sebalix Aug 28, 2023

Choose a reason for hiding this comment

sebalix Aug 28, 2023

Choose a reason for hiding this comment

jbaudoux Aug 28, 2023

Choose a reason for hiding this comment

LoisRForgeFlow Dec 12, 2023 • edited Loading

Choose a reason for hiding this comment

AaronHForgeFlow Dec 12, 2023

Choose a reason for hiding this comment

jbaudoux Dec 12, 2023

Choose a reason for hiding this comment

sebalix commented Oct 9, 2023

jbaudoux commented Oct 9, 2023

jbaudoux commented Oct 10, 2023

jbaudoux commented Nov 28, 2023

mt-software-de left a comment

Choose a reason for hiding this comment

mt-software-de Nov 28, 2023 • edited Loading

Choose a reason for hiding this comment

mt-software-de Nov 28, 2023

Choose a reason for hiding this comment

mt-software-de Jan 15, 2024

Choose a reason for hiding this comment

jbaudoux commented Apr 5, 2024 • edited Loading

mt-software-de left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 9, 2024

jbaudoux commented May 22, 2024

OCA-git-bot commented May 22, 2024

OCA-git-bot commented May 22, 2024

jbaudoux commented Aug 24, 2023 •

edited

Loading

LoisRForgeFlow Dec 12, 2023 •

edited

Loading

mt-software-de Nov 28, 2023 •

edited

Loading

jbaudoux commented Apr 5, 2024 •

edited

Loading