Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_inventory #1861

Merged
merged 8 commits into from
Jan 10, 2024
Merged

[16.0][MIG] stock_inventory #1861

merged 8 commits into from
Jan 10, 2024

Conversation

rousseldenis
Copy link
Contributor

No description provided.

@pfranck
Copy link

pfranck commented Oct 12, 2023

@rousseldenis Any help for this MR ?

@rousseldenis
Copy link
Contributor Author

rousseldenis commented Oct 12, 2023 •
edited
Loading

@rousseldenis Any help for this MR ?

@pfranck We are currently testing this one.

Any review is appreciated.

@JordiBForgeFlow
Copy link
Member

@rousseldenis Can you consider ForgeFlow@81ba4db?

@rafaelbn
Copy link
Member

/ocabot migration stock_inventory

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 13, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#1494) has not been updated to reference the current pull request because a previous pull request (#1666) is not closed.
Perhaps you should check that there is no duplicate work.
CC @Urvisha-OSI

@JordiBForgeFlow
Copy link
Member

@rafaelbn please do not yet merge as I asked @rousseldenis #1861 (comment)

@rousseldenis
Copy link
Contributor Author

@JordiBForgeFlow In fact, the commits are here:

image

@rousseldenis
Copy link
Contributor Author

@JordiBForgeFlow

This was referenced Nov 27, 2023
Merged
Closed
@rousseldenis
Copy link
Contributor Author

@JordiBForgeFlow Could you update your review ?

DorianMAG
DorianMAG approved these changes Jan 10, 2024
View reviewed changes
Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Runboat
LGTM

@flotho
Copy link
Member

flotho commented Jan 10, 2024

Hi @JordiBForgeFlow , any chance to update your review ?

flotho
flotho approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on runboat, it rpockks !
LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JordiBForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1861-by-JordiBForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d5e1861 into OCA:16.0 Jan 10, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 26073ff. Thanks a lot for contributing to OCA. ❤️

@AungKoKoLin1997 AungKoKoLin1997 mentioned this pull request Jan 31, 2024
Closed
@lmignon lmignon deleted the 16.0-mig-stock_inventory-dro branch February 14, 2024 14:03
agyamuta pushed a commit to ursais/stock-logistics-warehouse that referenced this pull request Feb 28, 2024
@OCA-git-bot @agyamuta
Merge PR OCA#1861 into 16.0
c84a3a2 
Signed-off-by JordiBForgeFlow

(cherry picked from commit d5e1861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorianMAG DorianMAG DorianMAG approved these changes

@JordiBForgeFlow JordiBForgeFlow JordiBForgeFlow approved these changes

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
10 participants
@rousseldenis @pfranck @JordiBForgeFlow @rafaelbn @OCA-git-bot @flotho @DorianMAG @DavidJForgeFlow @AlexPForgeFlow @Urvisha-OSI