[MIG] stock_exception: migration to 16.0

[mav-adhoc]

No description provided.

[yostashiro]

@mav-adhoc There is #1957 already. Would you review this instead?

[mav-adhoc]

@yostashiro Hi! This PR, apart from migrating the module to the 16 version, includes new features.

When we were testing the model, in case we choose 'stock.picking' as the model where we wanted to apply the exception, we noticed that the exception also ran when we confirmed sale orders.
This happens because, by confirming sale orders, the action confirm creates the respective records in stock.picking (IN/OUT, depending on the configuration you have) and run the exception.
What we wanted is to have the decision when to run the exception, if at the creation of the stock.picking record or if at the validation of the stock.picking record.

Due to this desire, we created two new boolean fields in the stock.exception class (check_on_validate and check_on_confirm) in order to indicate when to run the exception. If you select check_on_confirm, it will run the exception when you create the stock.picking record. If you select check_on_validate, it will run the exception when you validate the stock.picking record.

[yostashiro]

@mav-adhoc Thanks for explaining. We currently don't use this module so we may not be doing a thorough review, but I'd suggest splitting the new feature into a separate commit for ease of review and backporting.

[rousseldenis]

/ocabot migration stock_exception

[OCA-git-bot]

The migration issue (#1494) has not been updated to reference the current pull request because a previous pull request (#1957) is not closed.
Perhaps you should check that there is no duplicate work.
CC @Saran440

[mav-adhoc]

@rousseldenis we should close this PR or the previous one?

[mav-adhoc]

@yostashiro Hi! Can we merge this PR? Or we should merge the previous pull request (#1957) ?

[rousseldenis]

@yostashiro Hi! Can we merge this PR? Or we should merge the previous pull request (#1957) ?

@mav-adhoc The better is to ask @Saran440 what to do. As it was there before this, it is also fair to review that one instead.

[Saran440]

I checked this PR and #1957
it difference a little bit 8d6c626#diff-6cd14808c7b5610b6aedda5ec36d4cc5e66fd7839054d24788f2461897619687R41

However, I okay to use this PR.
Closed #1957

[Saran440]

Code Review 👍

[rousseldenis]

/ocabot migration stock_exception

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[mav-adhoc]

@OCA/tools-maintainers Merge please

[jcadhoc]

@OCA/tools-maintainers Merge please

[thomaspaulb]

This does not belong to tools. @OCA/stock... does not yield me any autofill, @pedrobaeza do you know what the correct ping is?

[rousseldenis]

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1965-by-rousseldenis-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at acfb321. Thanks a lot for contributing to OCA. ❤️