[IMP] stock_move_packaging_qty: report done packaging qtys #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shide
suggested changes
Apr 9, 2024
rousseldenis
requested changes
Apr 10, 2024
|
@yajo Could you check tests also ? |
yajo
force-pushed
the
16.0-smpq-done_pkg_qty
branch
from
68084a9
to
6c03fad
Compare
Shide
suggested changes
Apr 10, 2024
The title sounds like a simple task, but it requires many changes: - Store done pkg qtys in `stock.move.line` records. - The qtys are not computed. Instead, the user must write them by hand. This happens because many times the packaging just indicates an approximate content, but is not always exact until reaching this point of the process, where both the done qtys (both UoM and packagings) are measured and get real values. - Added compute and inverse on `stock.move` for simple scenarios where one move = one move line. - Add all this on all reports and views. This change also opens the door to be able to get a real inventory measured in product packagings. That's not implemented in this MVP, but the idea is recorded. @moduon MT-5531
yajo
force-pushed
the
16.0-smpq-done_pkg_qty
branch
from
6c03fad
to
ebb9ab7
Compare
yajo
commented
Apr 10, 2024
Shide
approved these changes
Apr 10, 2024
|
@rousseldenis @LoisRForgeFlow can we merge? 😄 ❤️ |
rousseldenis
approved these changes
Apr 11, 2024
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at c9a94fa. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title sounds like a simple task, but it requires many changes:
stock.move.linerecords.stock.movefor simple scenarios where one move = one move line.This change also opens the door to be able to get a real inventory measured in product packagings. That's not implemented in this MVP, but the idea is recorded.
@moduon MT-5531