Merge PR #383 into 14.0

Signed-off-by lmignon
OCA · Jul 10, 2024 · 96e9c32 · 96e9c32
2 parents 7b3cda3 + 66567fe
commit 96e9c32
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/storage_thumbnail/models/thumbnail_mixin.py b/storage_thumbnail/models/thumbnail_mixin.py
@@ -101,6 +101,7 @@ def get_existing_thumbnail(self, size_x, size_y, url_key=None):
         return thumbnail
 
     def get_or_create_thumbnail(self, size_x, size_y, url_key=None):
+        url_key = self._get_url_key(url_key)
         thumbnail = self.get_existing_thumbnail(size_x, size_y, url_key=url_key)
         if not thumbnail and self.data:
             vals = self.env["storage.thumbnail"]._prepare_thumbnail(

diff --git a/storage_thumbnail/tests/test_thumbnail.py b/storage_thumbnail/tests/test_thumbnail.py
@@ -51,6 +51,18 @@ def test_thumbnail(self):
         thumb.unlink()
         self.assertTrue(file_id.to_delete)
 
+    def test_image_get_or_create_thumbnail_no_duplicate(self):
+        # Ensure no duplicate is generated thanks to unique url_key
+        image = self._create_image()
+        self.assertTrue(image.url)
+        self.assertEqual(len(image.thumbnail_ids), 2)
+        thumb = image.thumb_small_id
+        thumb.url_key = "test"
+        existing_thumb = image.get_or_create_thumbnail(
+            thumb.size_x, thumb.size_y, url_key="TEST"
+        )
+        self.assertEqual(thumb, existing_thumb)
+
     def test_model(self):
         image = self._create_image()
         self.assertTrue(image.url)