Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][CHG] fs_base_multi_image: drag and drop fixes #332

Merged
merged 2 commits into from
May 15, 2024

Conversation

benwillig
Copy link
Contributor

@benwillig benwillig commented Jan 29, 2024

  • create in memory records instead of calling the ORM explicitly

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@benwillig benwillig changed the title [16.0][CHG] fs_base_multi_image: disable images drag and drop when parent record is not yet created [16.0][CHG] fs_base_multi_image: drag and drop fixes Feb 14, 2024
@lmignon
Copy link
Contributor

lmignon commented Feb 21, 2024

@benwillig Why do we need to create the relation on drag and drop? Can we add a relation and save it when the parent is saved?

@benwillig
Copy link
Contributor Author

@lmignon That's what I wanted to do, unfortunately I didn't find the right way to do it with the new framework.

@benwillig benwillig force-pushed the 16.0-disable_dnd_on_create-bwi branch from 075b27d to 119cb59 Compare May 7, 2024 09:21
@benwillig
Copy link
Contributor Author

@lmignon I finally found the way to make it work as it was in the old widget. And it also works when saving a specific image directly on the relation record.

@benwillig benwillig force-pushed the 16.0-disable_dnd_on_create-bwi branch from 119cb59 to a0b26a6 Compare May 7, 2024 09:26
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Works like a charm.

@lmignon
Copy link
Contributor

lmignon commented May 14, 2024

@bealdav Can you take a look at this?

@bealdav
Copy link
Member

bealdav commented May 14, 2024

Yes I 'll dive in.

@bealdav
Copy link
Member

bealdav commented May 14, 2024

Thanks for this improvement even if don't understand the full details.

Nice to see Kanban view completed with some fields.

As product.product view doesn't allow to edit images, don't you think that this view could show kanban view instead of tree ? It's a better visual view for users.

@benwillig
Copy link
Contributor Author

Yes we can display the kanban view by default. What do you think @lmignon ?

@lmignon
Copy link
Contributor

lmignon commented May 15, 2024

Yes we can display the kanban view by default. What do you think @lmignon ?

Yes we can on the product.product view.

Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. LGTM
Kanban in product.product view is a nice to have I think

@bealdav
Copy link
Member

bealdav commented May 15, 2024

It works nicely in prod db, really thanks

@bealdav
Copy link
Member

bealdav commented May 15, 2024

Also this PR #370 seems ok. What do you think ?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Comment on lines +27 to 35
>
<tree>
<field name="sequence" widget="handle" />
<field name="name" />
<field name="link_existing" invisible="1" />
<field name="image_id" invisible="1" />
<field name="image" invisible="1" />
<field name="specific_image" invisible="1" />
</tree>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is-it the right way to define the kanban?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a specific kanban view for the image relation model so we don't need to define an inline kanban view here (if this is what you asked).

@lmignon
Copy link
Contributor

lmignon commented May 15, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-332-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3baa17e into OCA:16.0 May 15, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1776ecb. Thanks a lot for contributing to OCA. ❤️

@ThomasBinsfeld ThomasBinsfeld deleted the 16.0-disable_dnd_on_create-bwi branch June 10, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants