-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][FIX] fs_attachment: fix constraint #363
Conversation
Hi @lmignon, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astirpe Thank you for the proposal. Can you add some comments into the code to explain why it's done as is and do the same into the commit message.
4a3bbec
to
48fa000
Compare
@lmignon done, could you check? |
This PR has the |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-363-by-gurneyalex-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@astirpe can you please rebase ? |
48fa000
to
5e644e5
Compare
The method _check_force_db_for_default_attachment_rules() encountered issues when used with a constraints() decorator due to the computed field use_as_default_for_attachments, which is not stored in the database. This fix consists in replacing the constraints() decorator with a directly invoked method.
5e644e5
to
f3af372
Compare
@hparfr @gurneyalex rebased, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
On my way to merge this fine PR! |
Congratulations, your PR was merged at 395af55. Thanks a lot for contributing to OCA. ❤️ |
Fixes #362