Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] fs_storage: Change make_path_posix() to only 1 argument #373

Merged
merged 1 commit into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fs_storage/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@
"security/ir.model.access.csv",
],
"demo": ["demo/fs_storage_demo.xml"],
"external_dependencies": {"python": ["fsspec"]},
"external_dependencies": {"python": ["fsspec>=2024.5.0"]},
}
2 changes: 1 addition & 1 deletion fs_storage/rooted_dir_file_system.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def _join(self, path):
# any relative paths.
# Since the path separator is not always the same on all systems,
# we need to normalize the path separator.
path_posix = os.path.normpath(make_path_posix(path, self.sep))
path_posix = os.path.normpath(make_path_posix(path))
root_posix = os.path.normpath(make_path_posix(self.path))
if not path_posix.startswith(root_posix):
raise PermissionError(
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# generated from manifests external_dependencies
fsspec
fsspec>=2024.5.0
python_slugify
Loading