[17.0][IMP] fs_storage: replace {db_name} in directory_path #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In multi database mode, there was no way to avoid filename collisions
vincent-hatakeyama
changed the title
|
@vincent-hatakeyama you should use one backend by database. IMO this change is useless. |
sbidoul
requested changes
Jul 12, 2024
There was a problem hiding this comment.
The use case is unclear to me and this could indeed be solved with a different backend configuration per database.
I can imagine this could facilitate the automatic creation of that backend.
This would need a test, and an update of the help text of the field to reveal the feature to users.
sbidoul
reviewed
Jul 12, 2024
| # replace {db_name} with the dbname | ||
| if field_name == "directory_path": | ||
| value = value.format(db_name=self.env.cr.dbname) | ||
| return value |
There was a problem hiding this comment.
This is also probably not the best place to implement this, as if we do this, it should not behave differently when the value is entered manually or via server environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multi database mode, there was no way to avoid filename collisions.
In multi database mode, without using that feature in fs_attachment, as the created filename does not contain the database name, it is possible to overwrite files from another database if obfuscation is off and the file have the same name and the same id or cause deletion of files if the checksum is used as the name and the same file is copied over several database and unlinked in one of them.
I would have prefer for the name of the file to always include the database name but I think it would have been a major change considered too breaking. Allowing to use the database name seemed more compatible.