-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] project_task_stage_allow_timesheet: invoice creation #739
[16.0][FIX] project_task_stage_allow_timesheet: invoice creation #739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have verified that is_timesheet
is set in the context for all cases where the user manipulates timesheets.
@FrancoMaxime @alexey-pelykh would you like to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: code review
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 7a56c15. Thanks a lot for contributing to OCA. ❤️ |
When the task is in a stage that doesn't allow timesheet you get an error when you want to invoice the timesheet already encoded. This fixes #738