Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] project_task_stage_allow_timesheet: invoice creation #739

Conversation

glitchov
Copy link

@glitchov glitchov commented Feb 6, 2025

When the task is in a stage that doesn't allow timesheet you get an error when you want to invoice the timesheet already encoded. This fixes #738

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have verified that is_timesheet is set in the context for all cases where the user manipulates timesheets.

@sbidoul
Copy link
Member

sbidoul commented Feb 14, 2025

@FrancoMaxime @alexey-pelykh would you like to review this?

@alexey-pelykh alexey-pelykh changed the title [FIX] project_task_stage_allow_timesheet: invoice creation [16.0][FIX] project_task_stage_allow_timesheet: invoice creation Feb 14, 2025
@alexey-pelykh alexey-pelykh added this to the 16.0 milestone Feb 14, 2025
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: code review

@sbidoul
Copy link
Member

sbidoul commented Feb 14, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-739-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7a56c15. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit cbdd5c7 into OCA:16.0 Feb 14, 2025
6 of 9 checks passed
@sbidoul sbidoul deleted the 16.0-fix-project_task_stage_allow_timesheet-invoice-creation-hda branch February 14, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants