Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] sale_timesheet_line_exclude: Add group to admin and default user template #741

Merged
merged 1 commit into from
Feb 28, 2025
Merged

[16.0][IMP] sale_timesheet_line_exclude: Add group to admin and default user template #741

merged 1 commit into from
Feb 28, 2025

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Feb 20, 2025

No description provided.

@CRogos CRogos changed the title [IMP] sale_timesheet_line_exclude: Add group to admin and default user template [16.0][IMP] sale_timesheet_line_exclude: Add group to admin and default user template Feb 20, 2025
@CRogos CRogos mentioned this pull request Feb 20, 2025
Open
JessBrandl
JessBrandl approved these changes Feb 25, 2025
View reviewed changes
Copy link

@JessBrandl JessBrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tested in runboat and worked as intended

@CRogos
Copy link
Contributor Author

CRogos commented Feb 25, 2025

@sbidoul could you review am merge?

@JessBrandl JessBrandl mentioned this pull request Feb 27, 2025
Open
@sbidoul
Copy link
Member

sbidoul commented Feb 27, 2025

@alexey-pelykh FYI

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos CRogos force-pushed the 16.0-imp-sale_timesheet_line_exclude-security branch from dad2ad5 to bbbf9cf Compare February 28, 2025 09:16
@CRogos
Copy link
Contributor Author

CRogos commented Feb 28, 2025

I've added the suggestion. The failing test should not be caused by this change.

@sbidoul
Copy link
Member

sbidoul commented Feb 28, 2025

@CRogos I propose a fix in #744

@sbidoul
Copy link
Member

sbidoul commented Feb 28, 2025

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-741-by-sbidoul-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0569948 into OCA:16.0 Feb 28, 2025
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 49cb41e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

@sbidoul sbidoul sbidoul approved these changes

@JessBrandl JessBrandl JessBrandl approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CRogos @sbidoul @OCA-git-bot @alexey-pelykh @JessBrandl