Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] hotel: Migration to 16.0 #192

Closed
wants to merge 118 commits into from

Conversation

norlinhenrik
Copy link

I have disabled some code and added this message: TODO: Fix this code for 16.0

Atul Makwana(SerpentCS) and others added 30 commits May 2, 2023 19:44
mymage and others added 20 commits May 2, 2023 19:44
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
Currently translated at 100.0% (520 of 520 strings)

Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel
Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel/it/
@norlinhenrik
Copy link
Author

Hello @JayVora-SerpentCS
I write to you since your company seems to be the main contributor.
I would like to rename some models and fields, e.g.

  • hotel.services -> hotel.service (singular name)
  • room_categ_id -> type_id (the related model is hotel.room.type)

@norlinhenrik
Copy link
Author

norlinhenrik commented May 29, 2023

Models to rename:

  • hotel.room.amenities -> hotel.room.amenity
  • hotel.room.amenities.type -> hotel.room.amenity.type
  • hotel.services -> hotel.service

Fields to rename:

  • order_line_id (instead of service_line_id) for hotel.service.line many2one relation to sale.order.line:
  • parent_id (instead of amenity_id / categ_id / service_id) when models are relating to themselves (hotel.room.amenities.type, hotel_room_type, hotel_service_type)
  • product_manager_id (instead of product_manager) relating to res.users (hotel.room, hotel.room.amenities, hotel.room.services)
  • type_id (instead of room_categ_id, amenities_categ_id, service_categ_id) when they refer to their type (hotel.room, hotel.room.amenities, hotel.room.services).

@ShwetaSerpentCS @Rajan-SerpentCS @JayVora-SerpentCS @dhruvitaSerpentCS @abdawone @mclaeysb Any thoughts?

@norlinhenrik
Copy link
Author

I will not continue with hotel migration to 16.0, because we are not going to use this module.

I leave the PR open so that someone else can benefit from the migration work that has been done so far.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 15, 2023
@github-actions github-actions bot closed this Nov 19, 2023
@JayVora-SerpentCS JayVora-SerpentCS removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 27, 2024
@nikul-serpentcs
Copy link
Member

Supersede #198

@JayVora-SerpentCS Please close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.