Open
Conversation
jwaes
force-pushed
the
18.0
branch
2 times, most recently
from
4c4a5e1 to
3771423
Compare
theangryangel
suggested changes
Feb 27, 2025
| @@ -43,7 +43,7 @@ repos: | |||
| hooks: | |||
Member
There was a problem hiding this comment.
These are managed via the https://github.com/OCA/oca-addons-repo-template. I'd guess this was from a pre-commit auto update?
These need to be cleared up before this'll go anywhere, or included as a separate PR.
| "Tecnativa, " | ||
| "OERP Canada," | ||
| "Odoo Community Association (OCA)", | ||
| "author": "Therp BV, Tecnativa, OERP Canada,Odoo Community Association (OCA)", |
Member
There was a problem hiding this comment.
There are changes to modules other than the one you've authored in this PR. I assume this is from an overeager pre-commit run against all files? Ideally you'd want this PR only touching/dealing with your new modules.
| "license": "AGPL-3", | ||
| "assets": { | ||
| "web.assets_backend": [ | ||
| "/web_iconify/static/lib/iconify/iconify-icon.js", |
Member
There was a problem hiding this comment.
If you're not using the minified version, do we need both in lib/iconify?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Odoo sticks with FontAwesome 4, we are missing out on a lot of icons. Iconify lets you use 'icons on demand' from a several open source collections