-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] shopfloor_reception: Ensure state assign of remaining move #882
base: 14.0
Are you sure you want to change the base?
[FIX] shopfloor_reception: Ensure state assign of remaining move #882
Conversation
Hi @JuMiSanAr, @mmequignon, |
@TDu @mmequignon @jbaudoux wms/shopfloor_reception/services/reception.py Line 1303 in c9cf770
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good according to the test but we need to be careful because all tests seem to rely on the fact that move lines are created by the picking type configuration.
In our case, the picking type is configured to not create move lines. The main difference is that the move line is created by the user and the quantity todo is 0. This could have an impact on partial processing.
Can you extend the tests to cover our real usage of the module ?
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
If there is not all processed for one move, we have to ensure that the state of the remaining move is still
assigned
.Otherwise the last remaining qty of this move will be not split into a own transfer.
wms/shopfloor_reception/services/reception.py
Line 1297 in c9cf770
wms/shopfloor/models/stock_move.py
Line 100 in c9cf770
cc @jbaudoux @TDu @mmequignon