Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] shopfloor_reception: Ensure state assign of remaining move #882

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

mt-software-de
Copy link
Contributor

@mt-software-de mt-software-de commented Apr 3, 2024

If there is not all processed for one move, we have to ensure that the state of the remaining move is still assigned.
Otherwise the last remaining qty of this move will be not split into a own transfer.

return selected_line.move_id.extract_and_action_done()

moves = self.filtered(lambda m: m.state == "assigned")

cc @jbaudoux @TDu @mmequignon

@OCA-git-bot
Copy link
Contributor

Hi @JuMiSanAr, @mmequignon,
some modules you are maintaining are being modified, check this out!

@mt-software-de
Copy link
Contributor Author

@TDu @mmequignon @jbaudoux
why did we choose to call the recompute_state?
I think that's not necessary since we calling action_assign immediately afterwards.

new_move._action_assign()

@mt-software-de mt-software-de changed the title [FIX] shopfloor_reception: Ensure state assign of remainig move [FIX] shopfloor_reception: Ensure state assign of remaining move Apr 4, 2024
@mt-software-de
Copy link
Contributor Author

ping @jbaudoux @TDu

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good according to the test but we need to be careful because all tests seem to rely on the fact that move lines are created by the picking type configuration.
In our case, the picking type is configured to not create move lines. The main difference is that the move line is created by the user and the quantity todo is 0. This could have an impact on partial processing.
Can you extend the tests to cover our real usage of the module ?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2024
@github-actions github-actions bot closed this Nov 17, 2024
@jbaudoux jbaudoux reopened this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants