Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding namespace and cluster for obs #335

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Adding namespace and cluster for obs #335

merged 1 commit into from
Dec 12, 2023

Conversation

schwesig
Copy link
Contributor

fixes nerc-project/operations#280
acm overlay & namespace added for nerc-ocp-obs

@schwesig schwesig self-assigned this Dec 12, 2023
@schwesig schwesig added the enhancement New feature or request label Dec 12, 2023
@schwesig schwesig requested review from larsks and computate December 12, 2023 17:11
@schwesig
Copy link
Contributor Author

reason for draft:
need input for decisison if the addition in cluster-scope/overlays/nerc-ocp-obs/ should be part of this PR as second commit or a new PR to separate connecting and configuration
@larsks @computate

@computate
Copy link
Member

Seems fine for the initial commit for obs in ACM before adding ArgoCD resources.

@schwesig schwesig marked this pull request as ready for review December 12, 2023 18:16
@larsks
Copy link
Member

larsks commented Dec 12, 2023

need input for decisison if the addition in cluster-scope/overlays/nerc-ocp-obs/

Smaller, focused pull requests are easier to review!

@larsks
Copy link
Member

larsks commented Dec 12, 2023

I would recommend updating the commit message to reference nerc-project/operations#280 (just like you've done in the PR description). Someone running git log only sees commit messages, not PR descriptions.

@schwesig
feat: adding namespace and cluster for obs
55a0318 
fixes nerc-project/operations#280
acm overlay & namespace added for nerc-ocp-obs

Signed-off-by: ​/Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
@schwesig schwesig force-pushed the 202312_basicConfigNewObsCluster branch from 7109649 to 55a0318 Compare December 12, 2023 19:49
@schwesig
Copy link
Contributor Author

I would recommend updating the commit message to reference nerc-project/operations#280 (just like you've done in the PR description). Someone running git log only sees commit messages, not PR descriptions.

Thanks, done that.

@schwesig schwesig merged commit 299201b into OCP-on-NERC:main Dec 12, 2023
@schwesig schwesig changed the title feat: adding namespace and cluster for obs Adding namespace and cluster for obs Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsks larsks larsks approved these changes

@computate computate computate approved these changes

@harshil-codes harshil-codes Awaiting requested review from harshil-codes

@jbasu01 jbasu01 Awaiting requested review from jbasu01

@bnshr bnshr Awaiting requested review from bnshr

@aabaris aabaris Awaiting requested review from aabaris

Assignees

@schwesig schwesig

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create basic configuration for observability cluster
3 participants
@schwesig @computate @larsks