Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure storage setup for the logging in obs cluster #348

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Configure storage setup for the logging in obs cluster #348

merged 1 commit into from
Jan 25, 2024

Conversation

bnshr
Copy link
Contributor

@bnshr bnshr commented Jan 22, 2024 •
edited
Loading

Refers #342

@bnshr bnshr marked this pull request as draft January 22, 2024 12:56
@bnshr bnshr force-pushed the configure-storage-obs branch 4 times, most recently from 2ba64e7 to 1fec461 Compare January 22, 2024 15:11
@bnshr bnshr marked this pull request as ready for review January 22, 2024 15:11
@bnshr bnshr force-pushed the configure-storage-obs branch 2 times, most recently from f665013 to e050401 Compare January 22, 2024 15:44
@bnshr bnshr force-pushed the configure-storage-obs branch from e050401 to 413a00e Compare January 22, 2024 16:24
@computate computate requested a review from larsks January 23, 2024 17:07
computate
computate reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@computate computate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, we can review this on Thursday morning.

...lays/nerc-ocp-obs/feature/odf/storageclasses/ocs-external-storagecluster-ceph-rbd_patch.yaml
Comment on lines +7 to +17
clusterID: openshift-storage
csi.storage.k8s.io/controller-expand-secret-name: rook-csi-rbd-provisioner
csi.storage.k8s.io/controller-expand-secret-namespace: openshift-storage
csi.storage.k8s.io/fstype: ext4
csi.storage.k8s.io/node-stage-secret-name: rook-csi-rbd-node
csi.storage.k8s.io/node-stage-secret-namespace: openshift-storage
csi.storage.k8s.io/provisioner-secret-name: rook-csi-rbd-provisioner
csi.storage.k8s.io/provisioner-secret-namespace: openshift-storage
imageFeatures: layering
imageFormat: "2"
pool: nerc_ocp_obs_1_rbd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsks we just wanted to double check, does this external ceph configuration for the storage on the obs cluster look good with these parameters?

schwesig
schwesig approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@schwesig schwesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good to me. just checked the storage in the call

@computate computate merged commit 4d4c9b7 into OCP-on-NERC:main Jan 25, 2024
2 checks passed
schwesig added a commit to schwesig/OCP-on-NERC_nerc-ocp-config that referenced this pull request Jan 26, 2024
@schwesig
Add clusterroles rbac to obs cluster and clean-up
29abd63 
- affects obs-cluster
- add clusterroles rbac
- streamline: remove redundant github-client-secret.yaml (follow OCP-on-NERC#316)
- adjust kustomization.yaml to that
- cleanup: remove oauths-clientsecret-nerc, keycloak.mss not needed
  (yet)
-adjust rook-ceph-external-cluster to fit to changes in OCP-on-NERC#348

fixes nerc-project/operations#308

Signed-off-by: ​/Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
@schwesig schwesig mentioned this pull request Jan 26, 2024
Merged
schwesig added a commit to schwesig/OCP-on-NERC_nerc-ocp-config that referenced this pull request Jan 26, 2024
@schwesig
Add clusterroles rbac to obs cluster and clean-up
b14874d 
- affects obs-cluster
- add clusterroles rbac
- streamline: remove redundant github-client-secret.yaml (follow OCP-on-NERC#316)
- adjust kustomization.yaml to that
- cleanup: remove oauths-clientsecret-nerc, keycloak.mss not needed
  (yet)
-adjust rook-ceph-external-cluster to fit to changes in OCP-on-NERC#348

fixes nerc-project/operations#308

Signed-off-by: ​/Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
schwesig added a commit to schwesig/OCP-on-NERC_nerc-ocp-config that referenced this pull request Jan 26, 2024
@schwesig
Add clusterroles rbac to obs cluster and clean-up
4c2e446 
- affects obs-cluster
- add clusterroles rbac
- streamline: remove redundant github-client-secret.yaml (follow OCP-on-NERC#316)
- adjust kustomization.yaml to that
- cleanup: remove oauths-clientsecret-nerc, keycloak.mss not needed
  (yet)
-adjust rook-ceph-external-cluster to fit to match changes in OCP-on-NERC#348

fixes nerc-project/operations#308

Signed-off-by: ​/Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
schwesig pushed a commit to schwesig/OCP-on-NERC_nerc-ocp-config that referenced this pull request Jan 26, 2024
@bnshr @schwesig
Add clusterroles rbac to obs cluster and clean-up
895cc8d 
- affects obs-cluster
- add clusterroles rbac
- streamline: remove redundant github-client-secret.yaml (follow OCP-on-NERC#316)
- adjust kustomization.yaml to that
- cleanup: remove oauths-clientsecret-nerc, keycloak.mss not needed
  (yet)
-adjust rook-ceph-external-cluster to fit to match changes in OCP-on-NERC#348

fixes nerc-project/operations#308

Signed-off-by: ​/Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
schwesig added a commit to schwesig/OCP-on-NERC_nerc-ocp-config that referenced this pull request Jan 26, 2024
@schwesig
Add clusterroles rbac to obs cluster and clean-up
90ab74d 
- affects obs-cluster
- add clusterroles rbac
- streamline: remove redundant github-client-secret.yaml (follow OCP-on-NERC#316)
- adjust kustomization.yaml to that
- cleanup: remove oauths-clientsecret-nerc, keycloak.mss not needed
  (yet)
-adjust rook-ceph-external-cluster to fit to match changes in OCP-on-NERC#348

fixes nerc-project/operations#308

Signed-off-by: ​/Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
schwesig added a commit to schwesig/OCP-on-NERC_nerc-ocp-config that referenced this pull request Jan 29, 2024
@schwesig
Add clusterroles rbac to obs cluster and clean-up
79f2d32 
- affects obs-cluster
- add clusterroles rbac
- streamline: remove redundant github-client-secret.yaml (follow OCP-on-NERC#316)
- adjust kustomization.yaml to that
- cleanup: remove oauths-clientsecret-nerc, keycloak.mss not needed
  (yet)
-adjust rook-ceph-external-cluster to fit to match changes in OCP-on-NERC#348

fixes nerc-project/operations#308

Signed-off-by: ​/Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
schwesig added a commit that referenced this pull request Jan 30, 2024
@schwesig
Add clusterroles rbac to obs cluster and clean-up (#351)
6ff4d58 
- affects obs-cluster
- add clusterroles rbac
- streamline: remove redundant github-client-secret.yaml (follow #316)
- adjust kustomization.yaml to that
- cleanup: remove oauths-clientsecret-nerc, keycloak.mss not needed
  (yet)
-adjust rook-ceph-external-cluster to fit to match changes in #348

fixes nerc-project/operations#308

Signed-off-by: ​/Thor(sten)?/ Schwesig <89909507+schwesig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@computate computate computate approved these changes

@schwesig schwesig schwesig approved these changes

@harshil-codes harshil-codes Awaiting requested review from harshil-codes

@jbasu01 jbasu01 Awaiting requested review from jbasu01

@larsks larsks Awaiting requested review from larsks

Assignees

@bnshr bnshr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnshr @computate @schwesig