switch from ::: to using getFromNamespace and add test for sql_translation.DatabaseConnectorConnection

Author: ablack3

R/backend-DatabaseConnector.R

@@ -5,24 +5,18 @@ dbplyr_edition.DatabaseConnectorConnection <- function(con) {
   2L
 }
 
-
-
 #' @export
 #' @importFrom dbplyr sql_translation 
 sql_translation.DatabaseConnectorJdbcConnection <- function(con) {
 
   switch(dbms(con),
-     "oracle" = dbplyr:::sql_translation.Oracle(con),
-     "postgresql" = dbplyr:::sql_translation.PqConnection(con),
-     "redshift" = dbplyr:::sql_translation.RedshiftConnection(con),
-     "sql server" = `dbplyr:::sql_translation.Microsoft SQL Server`(con),
-     "bigquery" = dbplyr:::sql_translation.BigQueryConnection(con),
-     "sqlite" = dbplyr:::sql_translation.SQLiteConnection(con),
-     "sqlite extended" = dbplyr:::sql_translation.SQLiteConnection(con),
-     "spark" = `dbplyr:::sql_translation.Spark SQL`(con),
-     "snowflake" = dbplyr:::sql_translation.Snowflake(con),
-     "synapse" = `dbplyr:::sql_translation.Microsoft SQL Server`(con),
-     "duckdb" = duckdb:::sql_translation.duckdb_connection(con),
+     "oracle" = utils::getFromNamespace("sql_translation.Oracle", "dbplyr")(con),
+     "postgresql" = utils::getFromNamespace("sql_translation.PqConnection", "dbplyr")(con),
+     "redshift" = utils::getFromNamespace("sql_translation.RedshiftConnection", "dbplyr")(con),
+     "sql server" = utils::getFromNamespace("sql_translation.Microsoft SQL Server", "dbplyr")(con),
+     "bigquery" = utils::getFromNamespace("sql_translation.BigQueryConnection", "bigrquery")(con),
+     "spark" = utils::getFromNamespace("sql_translation.Spark SQL", "dbplyr")(con),
+     "snowflake" = utils::getFromNamespace("sql_translation.Snowflake", "dbplyr")(con),
+     "synapse" = utils::getFromNamespace("sql_translation.Microsoft SQL Server", "dbplyr")(con),
      rlang::abort("Sql dialect is not supported!")) 
 }
-

tests/testthat/test-dbplyr.R

@@ -27,3 +27,13 @@ for (testServer in testServers) {
 #   
 #   expect_equal(day(date), c(1, 31, 31))
 # })
+
+test_that("dbplyr::sql_translation works with jdbc connections", {
+  DatabaseConnectorJdbcDrivers <- c("sql server", "oracle", "postgresql", "redshift", "bigquery", "snowflake", "synapse", "spark")
+  for (db in DatabaseConnectorJdbcDrivers) {
+    version <- if (db %in% c("sql server", "synapse")) "15" else NULL
+    con <- dbplyr::simulate_dbi("DatabaseConnectorJdbcConnection", dbms = db, version = version)
+    testthat::expect_is(dbplyr::sql_translation(con), "sql_variant")
+  }
+})
+