Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize Teradata in WhiteRabbit #382

Open
janblom opened this issue Jul 14, 2023 · 0 comments
Open

Normalize Teradata in WhiteRabbit #382

janblom opened this issue Jul 14, 2023 · 0 comments
Assignees
Labels
enhancement WhiteRabbit Issue concerning the creation of scan report

Comments

@janblom
Copy link
Collaborator

janblom commented Jul 14, 2023

Is your feature request related to a problem? Please describe.
There are several issues with the Teradata database connector support in WhiteRabbit

  • the dependencies are (old) copies of jars, instead of normal maven dependencies
  • it is not possible to test the connector in an automated test without external dependencies
  • it is unknown whether there is an actual use of/interest in the Teradata connector

Describe the solution you'd like
The current version of the Teradata jdbc jar has version 16.0.0.32, and appears to have a dependency on com.teradata.tdgss.tdgssconfig version 16.0.0.0 (also a copied jar). Teradata jdbc is available as a normal dependency on Maven Central with version 16.20.00.13. This version no longer seems to depend on the tdgssconfig jar.
Solution: have Teradata 16.20.00.13 as a normal dependency, remove the old libraries from the source tree.

Describe alternatives you've considered
Deprecate and remove Teradata.

Additional context
Please not that both before and after the implementation of this issue, the Teradata connector can not be tested. Since the version update is only on patch level, it is expected that the connector will work (or not work) as before.

@janblom janblom self-assigned this Jul 14, 2023
@janblom janblom added the WhiteRabbit Issue concerning the creation of scan report label Jul 14, 2023
janblom pushed a commit to thehyve/OHDSI-WhiteRabbit that referenced this issue Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement WhiteRabbit Issue concerning the creation of scan report
Projects
None yet
Development

No branches or pull requests

1 participant