fix(segmentation-tools): toggle passive and active tool modes based on segment actions

[Devu-trenser]

Context

• To set segmentation tool mode passive on removing all segments from the segmentation.
• To activate segmentation tools on adding segments, activating segmentation having at least one segment, or switching between segmentation.
• This PR has been incorporated by FlyWheel.io.
• Close [Bug] Segmentation tool remains active after deleting all segments, and new segments cannot be added #4632

Changes & Results

Changes to

• Set segmentation tools to passive mode when all segments are removed from the segmentation.
• Activate segmentation tools when:
  1. Adding new segments.
  2. Activating a segmentation that contains at least one segment.
  3. Switching between segmentations that contain segments.
• Prevent -infinity segmentation index when adding a new segment after deleting all segments.

Results:

• Segmentation tools are disabled if the active segmentation does not contain any segments.
• Segmentation tools are reactivated when:
  1. Adding segments.
  2. Activating a segmentation with at least one segment.
  3. Switching between segmentations with segments.
• The user can add a new segment after deleting all segments from a segmentation.

OSS4633.mp4

Testing

• Verify that segmentation tools are disabled if the active segmentation does not contain any segments
• Verify that segmentation tools are active when adding a new segment, activating a segmentation with at least one segment, or switching between segmentations that contain segments.
• Verify user is able to add new segment after deleting all segments.

Checklist

PR

• My Pull Request title is descriptive, accurate and follows the
  semantic-release format and guidelines.

Code

• My code has been well-documented (function documentation, inline comments,
  etc.)

Public Documentation Updates

• The documentation page has been updated as necessary for any public API
  additions or removals.

Tested Environment

• OS:
• Node version:
• Browser:

[netlify]

✅ Deploy Preview for ohif-platform-docs canceled.

Name	Link
🔨 Latest commit	588fca0
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/67adeb2367910d0008b8470d

[netlify]

✅ Deploy Preview for ohif-dev canceled.

Name	Link
🔨 Latest commit	588fca0
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/67adeb24ab0c460008d41b60

[Devu-trenser]

@sedghi Could you please review this PR and let me know if it's possible to include these changes in 3.9?

[sedghi]

I reviewed this PR last week and I'm pretty sure it's not the right approach. I need to think about how to fix this issue, but it's definitely not this way. One problem is that SegmentationTools are hardcoded in that file, which doesn't make sense.
The right approach is to let the evaluator handle the disabled state, and have the segmentation service simply publish events.

[Jaseel-trenser]

@sedghi We have implemented a new approach by adding listeners to the Segmentation Tools, similar to what we did for the ReferenceLines Tool. With these changes, modifications to the Segmentation Service have been removed, and it now simply publishes events. Additionally, we have removed the hardcoded Segmentation Tools.

However, we encountered a performance issue due to multiple event subscriptions. To address this, we have implemented an unsubscribe mechanism before subscribing to events https://github.com/Devu-trenser/Viewers/blob/fix-brush-tool-is-active-after-deleting-segments-from-segmentation/extensions/cornerstone/src/init.tsx#L289, ensuring optimal performance.

Could you please review the latest changes?

[sedghi]

I don't think we need this pull request anymore; I've already added the two fixes here: https://github.com/OHIF/Viewers/pull/4782. I don't really understand all the other complexities in this pull request for addressing issue https://github.com/OHIF/Viewers/issues/4632.

[sedghi]

What do you think

[sedghi]

we don't need this anymore right?

[Devu-trenser]

we don't need this anymore right?

@sedghi The issue has been resolved. When deleting all segments, the segmentation tools are now disabled, and we are able to create new segments. However, we can still see a black cursor in the viewport as seen in the below attached screenshot. Is this black cursor intended as a feature to indicate that brushing in the viewport is not possible?
This PR was hiding the brush cursor when not applicable.

cc: @Jaseel-trenser @arul-trenser