fix(core): Address 3D reconstruction and Android compatibility issues and clean up 4D data mode #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add case-insensitive protocol ID lookup in HangingProtocolService - Update MPR protocol name to be more descriptive - Simplify protocol name/ID validation logic
- Introduce getCustomizationModule for DICOM microscopy extension - Add panelMeasurementItem customization for microscopy measurement panel - Update MeasurementTable to use customizable measurement item component
…improved defaults - Add support for controlled and uncontrolled states in Numeric component - Implement default value calculations for single and double range inputs - Update NumericMetaShowcase to demonstrate controlled state usage - Export Numeric component in ui-next index
…trols - Rename and simplify state variables for dimension group range - Improve range slider with number inputs and dynamic range calculation - Remove unnecessary state management and console logging - Update dynamic volume controls to use more precise range selection
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev canceled.
|
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Detail:
This pull request includes updates to several dependencies and significant changes to the
DynamicVolumeControlscomponent to improve its functionality and align with the latest version of the cornerstone library. The most important changes include updating the cornerstone dependencies, refactoring theDynamicVolumeControlscomponent, and updating the CinePlayer component to handle dimension groups instead of time points.Dependency updates:
@cornerstonejs/adapters,@cornerstonejs/core, and@cornerstonejs/toolsdependencies to version 2.19.2 in multiplepackage.jsonfiles. [1] [2] [3] [4] [5] [6]This will fix majority of the issue and close #4286
Refactoring
DynamicVolumeControlscomponent:FrameControlswithDimensionGroupControlsand updated related state variables and methods inDynamicVolumeControls.tsx. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]PanelGenerateImage.tsxto use dimension groups instead of time points, including changes to state variables and event handling. [1] [2] [3] [4] [5] [6] [7]Updating CinePlayer component:
CinePlayer.tsxto handle dimension groups for dynamic volumes, including changes to event listeners and state updates. [1] [2] [3]