-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui(components): Adds InputNumber component and 4d panel updates #4874
Open
dan-rukas
wants to merge
23
commits into
OHIF:master
Choose a base branch
from
dan-rukas:feat/panel-layout-4d
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev canceled.
|
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
no longer needs div wrapper in implementation
Note: The label for "Frame" was mislabeled "Group". This is fixed now. |
- Introduced 'stepper' mode in Numeric component for enhanced number input functionality. - Added StepInput, HorizontalControls, and VerticalControls sub-components to manage stepper controls. - Updated NumericMetaContext to support stepper mode and handle value changes accordingly. - Enhanced documentation for new features in Numeric showcase. ff Refactor Numeric component to replace StepInput with NumberStepper - Replaced StepInput sub-component with NumberStepper for improved control handling. - Updated Numeric showcase to utilize NumberStepper for frame, opacity, and zoom inputs. - Removed HorizontalControls and VerticalControls for a more streamlined implementation. - Enhanced error handling and component structure for better maintainability.
…erStepper components - Updated NumberStepper components to include additional styling and a label for FPS. - Adjusted layout for Opacity and Zoom controls to ensure consistent spacing and alignment. - Refactored class names for better responsiveness and visual consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces a new flexible
InputNumber
component with vertical and horizontal controls toui-next
. In addition, 4d panel components are migrated toui-next
includingWindowLevel
.Changes & Results
InputNumber
componentUsage examples
Basic Usage with Horizontal Controls
Vertical Controls Example
Decimal Number Example
Additional Panel updates preview
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment