Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpn log/v2 #11198

Closed
wants to merge 4 commits into from
Closed

Alpn log/v2 #11198

wants to merge 4 commits into from

Conversation

victorjulien
Copy link
Member

SV_BRANCH=OISF/suricata-verify#1873

https://redmine.openinfosecfoundation.org/issues/7055

Looking for feedback on the logging format. From the test:

  "tls": {
    "sni": "cloudflare-quic.com",
    "version": "TLS 1.3",
    "client_alpns": [
      "h2",
      "http/1.1"
    ]
  }

For later logging and detection.
Part of the extended logging.

Logs `client_alpns` and `server_alpns` arrays in the tls object.

Ticket: OISF#7055.
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.97%. Comparing base (aeb200e) to head (c6d059e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11198      +/-   ##
==========================================
- Coverage   82.98%   82.97%   -0.02%     
==========================================
  Files         942      942              
  Lines      250838   250865      +27     
==========================================
- Hits       208147   208144       -3     
- Misses      42691    42721      +30     
Flag Coverage Δ
fuzzcorpus 61.31% <93.02%> (+0.01%) ⬆️
livemode 18.78% <0.00%> (-0.01%) ⬇️
pcap 44.60% <90.69%> (+0.01%) ⬆️
suricata-verify 61.62% <90.69%> (-0.01%) ⬇️
unittests 60.66% <67.44%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 20885

@victorjulien victorjulien mentioned this pull request Jun 1, 2024
@victorjulien
Copy link
Member Author

continued in #11204

@victorjulien victorjulien mentioned this pull request Jun 18, 2024
@victorjulien victorjulien deleted the alpn-log/v2 branch June 23, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants