next/486/20240618/v1 #11326
Merged
next/486/20240618/v1 #11326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a signature uses a condition that requires a real packet, filter out pseudo packets as early as possible. To do this, the SignatureMask logic is used. This allows for the removal of checks for pseudo packets in individual keywords `Match` functions, which will be done in a follow up commit. Update analyzer to output the new flag. Ticket: OISF#7002.
Keep as debug validation check.
Use a typedef'd function pointer for packet Prefilter callbacks to make the code consistent with the other callbacks.
Add an argument to the packet prefilter registration function to include `SignatureMask` flags. This will be used at runtime to only call these prefilter engines when the mask check passes.
Often used with stream content, which can be inspected with pseudo packets.
This is now handled at registration with SIG_MASK_REQUIRE_REAL_PKT.
This is now handled at registration with SIG_MASK_REQUIRE_REAL_PKT.
Previously it was run once a week, hiding some issues until Monday's. Instead run on pull requests, but still not every push.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11326 +/- ##
==========================================
- Coverage 82.48% 82.41% -0.07%
==========================================
Files 934 934
Lines 252239 247239 -5000
==========================================
- Hits 208070 203773 -4297
+ Misses 44169 43466 -703
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 21129 |
jasonish
approved these changes
Jun 19, 2024
This was referenced Jun 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#1925