-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Libhtp rs v27.1 small step for src #12474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust Mainly using htp_header_value_ptr and htp_header_value_len when possible
In preparation of libhtp rust Mainly adding some const
In preparation of libhtp rust
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12474 +/- ##
=======================================
Coverage 80.52% 80.53%
=======================================
Files 923 923
Lines 259176 259179 +3
=======================================
+ Hits 208708 208732 +24
+ Misses 50468 50447 -21
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 24362 |
victorjulien
approved these changes
Jan 27, 2025
Merged
Merged in #12492, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/2696
Describe changes:
This allow to go one small step further
The big libhtp-rs commit will remove app-layer-htp-libhtp.h which defines these aliases
#12442 next round
Draft : I am not sure the
const
change will please every compiler but it passed locally for me...git diff libhtp-rs-v27 --name-only -- src/
givesNULL
check for h, not onlyhtp_header_value(h)
❔