detect/csum: rm interaction btw stream setting/csum #12482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 7467 Stream checksum validation no longer has a side effect of setting PKT_IGNORE_CHECKSUM and thus, no longer affects csum keyword checks.
Describe the change of behavior between the stream.checksum-validation setting and checksum-based rule keywords.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12482 +/- ##
==========================================
- Coverage 80.52% 80.43% -0.10%
==========================================
Files 923 923
Lines 259176 259172 -4
==========================================
- Hits 208708 208455 -253
- Misses 50468 50717 +249
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24365 |
victorjulien
approved these changes
Jan 27, 2025
Merged
|
Merged in #12499, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #12479
Issue: 7467
Stream checksum validation no longer has a side effect of setting PKT_IGNORE_CHECKSUM and thus, no longer affects csum keyword checks.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7467
Describe changes:
Updates:
NB: Updated s-v test link: no functional changes in new pr.
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2258
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=