Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

af-packet: clean up IPS config check #12510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

victorjulien
Copy link
Member

Don't emmit generic error statements on things that are not errors. Instead, for cases where (part of) the config is missing, use the defaults and log only a more detailed explanation at the 'config' level.

Minor code cleanups.

Replaces #12397

Don't emmit generic error statements on things that are not errors. Instead,
for cases where (part of) the config is missing, use the defaults and log
only a more detailed explanation at the 'config' level.

Minor code cleanups.
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.56%. Comparing base (cfbf8fd) to head (817e5f8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12510   +/-   ##
=======================================
  Coverage   80.56%   80.56%           
=======================================
  Files         925      925           
  Lines      259292   259291    -1     
=======================================
  Hits       208906   208906           
+ Misses      50386    50385    -1     
Flag Coverage Δ
fuzzcorpus 56.15% <0.00%> (+<0.01%) ⬆️
livemode 19.39% <45.00%> (-0.01%) ⬇️
pcap 44.20% <0.00%> (+<0.01%) ⬆️
suricata-verify 63.40% <0.00%> (+<0.01%) ⬆️
unittests 58.44% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants