decode/ethertype: Event on unknown ethertype #12511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 7129 Create a decode/engine event if unknown ethertypes are observed.
Issue: 7129 Document the unknown ethertype event.
Issue 7129 When configured with the existing "ethernet" switch, include the ether type in the output. This is most useful with anomaly records indicating unknown ethertypes.
jlucovsky
requested review from
jufajardini,
victorjulien and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12511 +/- ##
==========================================
+ Coverage 80.56% 80.57% +0.01%
==========================================
Files 925 925
Lines 259292 259294 +2
==========================================
+ Hits 208906 208936 +30
+ Misses 50386 50358 -28
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Jan 30, 2025
Merged
|
Information: QA ran without warnings. Pipeline 24460 |
|
Merged in #12514, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #12495
Issue: 7129
Create a decode/engine event if unknown ethertypes are observed.
Note: this PR results in 2 counters tracking unknown ethertypes; https://redmine.openinfosecfoundation.org/issues/7528 tracks the removal of the non-event value.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7129
Describe changes:
Updates
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#1954
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=