detect/integers: add support for negated strings when enum is used - v4 #12516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function detect_parse_uint_enum can parse strings like !bind_request Ticket: OISF#7513
This was referenced Jan 31, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12516 +/- ##
==========================================
- Coverage 80.70% 80.68% -0.02%
==========================================
Files 925 925
Lines 258914 258920 +6
==========================================
- Hits 208949 208913 -36
- Misses 49965 50007 +42
Flags with carried forward coverage won't be shown. Click here to find out more. |
jufajardini
reviewed
Jan 31, 2025
catenacyber
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Thanks for the work :-) all good for me now
CI : 🟢
Code : good
Commits segmentation : ok
Commit messages : good
Git ID set : looks fine for me
CLA : you already contributed
Doc update : thanks for adding
Redmine ticket : ok
Rustfmt : good :-)
Tests : ok now
Dependencies added: none
victorjulien
approved these changes
Feb 11, 2025
Merged
|
Merged in #12562, thanks! |
|
Thanks Alice :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #7513
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/issues/7513
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7513
Describe changes:
SV_BRANCH=OISF/suricata-verify#2271
Previous PR = #12484