userguide: document flow_id, with examples - v5 #9800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flow_id explanation expanded from version shared by Peter Manev. Task OISF#6445
jufajardini
commented
Nov 16, 2023
Comment on lines
+56
to
+59
| The ability to correlate any existing evidence/logs to an alert and/ or the | ||
| ability to correlate all logs belonging to a specific session/flow was | ||
| introduced in 2014 (see `commit f1185d051c21 <https://github.com/OISF/suricata/ | ||
| commit/f1185d051c210ca0daacdddbe865a51af24f4ea3>`_). |
There was a problem hiding this comment.
Maybe better:
"The ability to correlate EVE logs belonging to a specific session/flow was introduced by..."
way more succinct, since we basically have already mentioned all the correllation that can be done in the previous paragraph...
There was a problem hiding this comment.
Yes, it sounds better to me. It also removes existing, cause it can help correlate yet to be logged events as well.
|
New version, @pevma ^^ |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9800 +/- ##
==========================================
- Coverage 82.45% 82.37% -0.09%
==========================================
Files 968 968
Lines 273866 273866
==========================================
- Hits 225825 225592 -233
- Misses 48041 48274 +233
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Replaced by: #9809 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow_id explanation expanded from version shared by Peter Manev.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6445
Previous PR: #9794
Changes from previous PR:
Results: https://suri-rtd-test.readthedocs.io/en/doc-flow-id-v5/output/eve/eve-json-format.html#flow-id