Skip to content
This repository was archived by the owner on Apr 6, 2025. It is now read-only.

Initial support för SalesOrderV3 and VismaConnect #199

Closed
wants to merge 43 commits into from

Conversation

angoyd
Copy link
Contributor

@angoyd angoyd commented Mar 8, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Mar 8, 2023

  • CustomerTest.cs:
    • Changed id to subaccountNumber in salesSubaccount object
  • LocationTests.CanDeserializeToEntity.verified.txt:
    • Added active property for bAccount and changed type from string to IdDescription (id, description) for contact and location objects
      3-4 SalesOrderTests.* : added overrideNumberSeries boolean value with default false value when creating new order or updating existing one; if true then the number series will be overridden by the specified values of documentTypeId/number properties on POST request body otherwise it is ignored even if provided as part of PUT request body (when updating an existing order). This change was made because we were getting 400 Bad Request error response code whenever trying to update a salesorder's number using VismaNetApi library version 1..0...1 but not anymore after this fix has been applied! :)
  • Added VismaConnectClientId,VismaConnectClientSecret,VismaConnectTenantId and VismaconnectScopes to the authorization class.
  • Changed defaultWarehouse from DescriptiveDto to string in Inventory model
  • Removed baccount property from Location model as it is not used anywhere else than when creating a new location object (which we don't do)
  • Added support for .net 6
  • Fixed copyright year in nuget package description and assembly info file
  • Updated Newtonsoft Json to 13.0.1 (latest stable)
  • Removed obsolete code from ClientSalesOrderV3 class, which was used when Visma Connect did not exist yet - this is now the only way of authenticating with Sales Order API v3 so it can be removed safely without breaking anything else than old versions of Visma Net Api library that are no longer supported anyway since they were released before we had a public release on NuGet at all!
  • Added a new class SupplierPaymentData
  • Updated LocationData to use baccount instead of baccountId
  • Removed obsolete SalesOrder and added SalesOrderV3 which is the replacement for it (Salesorder will be deprecated in 2023)
  • Added GetAllItemClasses() method to InventoryData, this returns all item classes from VismaNet ERP API v1/inventory/itemclass endpoint
  • Changed how token is fetched when using OAuth authentication flow by adding client_id and secret as parameters on GetTokenUsingOAuth(...) function call
  • Added support for Visma Connect
  • Fixed bug in GetStream method, where the response was not handled correctly if it contained an error message from API (e.g., "The requested resource does not exist")

@traventusAY
Copy link
Collaborator

@sierdweidema I have added initial support for Order V3, and some initial conversion functions. After some discussions with ole some time ago we decided to add it in an own project, please let me know what you think about it.

@omelhus omelhus closed this Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants