Skip to content

Logs for IGM 2.0 & RSF 2.0 #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025

Conversation

adarsh-206
Copy link

No description provided.

Copy link
Collaborator

@ParneetkaurDev ParneetkaurDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In RSF Flow2
settle2,on_settle2 missing.

@adarsh-206
Copy link
Author

@ParneetkaurDev Please check now. I have updated rsf flow 2 logs.

@ParneetkaurDev
Copy link
Collaborator

@adarsh-206

Flow 5 is mandatory for the Buyer; please ensure it is included.

@adarsh-206
Copy link
Author

@adarsh-206

Flow 5 is mandatory for the Buyer; please ensure it is included.

@ParneetkaurDev Please consider the latest commit. I have added rsf flow 5.

@adarsh-206
Copy link
Author

adarsh-206 commented May 2, 2025 via email

@ParneetkaurDev
Copy link
Collaborator

@adarsh-206

I reviewed the flow, and it should be Flow 5 (NIL flow). However, the response being sent corresponds to the NP-NP flow. Please review and correct this as per the mock server guide. Kindly ensure all flows align with the definitions provided in the document.
Mock Server Guide

@adarsh-206
Copy link
Author

@adarsh-206

I reviewed the flow, and it should be Flow 5 (NIL flow). However, the response being sent corresponds to the NP-NP flow. Please review and correct this as per the mock server guide. Kindly ensure all flows align with the definitions provided in the document. Mock Server Guide

@ParneetkaurDev Please consider the latest commit again. I have changes logs for Flow 5 (NIL flow). The other report, on_report, recon, and on_recon were showing errors in utility, I guess those are not applicable in case of NIL. Please review this.

@ParneetkaurDev ParneetkaurDev merged commit c245741 into ONDC-Official:master May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants