Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion component #4080

Merged
merged 8 commits into from
Jan 27, 2025
Merged

Accordion component #4080

merged 8 commits into from
Jan 27, 2025

Conversation

CrowsVeldt
Copy link
Contributor

@CrowsVeldt CrowsVeldt commented Jan 16, 2025 •
edited
Loading

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)
  • Code style update
  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Describe the new behaviour
If useful, provide screenshot or capture to highlight main changes

Does this PR introduce a breaking change?

  • Yes
  • No

Git Issues

Closes #3786

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@CrowsVeldt CrowsVeldt requested a review from a team as a code owner January 16, 2025 16:40
@CrowsVeldt
Copy link
Contributor Author

The 'Current Email' subtitle doesn't have the underline anymore. I wasn't sure how to add it without making a specific case just for the email form.

benfurber
benfurber requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@benfurber benfurber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @CrowsVeldt. A few minor bits, plus you need to run yarn format.

packages/components/src/Accordion/Accordion.stories.tsx Outdated Show resolved Hide resolved
packages/components/src/Accordion/Accordion.stories.tsx Outdated Show resolved Hide resolved
packages/components/src/Accordion/Accordion.test.tsx Outdated Show resolved Hide resolved
packages/components/src/index.ts Outdated Show resolved Hide resolved
@benfurber benfurber force-pushed the accordion-component branch from cc7f3d5 to d48ab53 Compare January 17, 2025 15:26
@benfurber benfurber added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jan 17, 2025
@benfurber
Copy link
Member

@CrowsVeldt Just QA'd it.

  1. Can you please add a change of mouse cursor on hover, so it's clearer where users can click.
  2. Can you reorder them so that password change is first.
  3. Can you please add the subheading for the change password.

@benfurber
Copy link
Member

@CrowsVeldt Awesome, thank you! Just run yarn format again and I think it'll be ready to merge in.

@benfurber
Copy link
Member

Looks like the test isn't passing. If you run yarn test in the components folder you should see it. If you have a look at other uses of not.toBeInTheDocument() you should be able to work out what needs fixing.

@CrowsVeldt
Copy link
Contributor Author

Looks like the test isn't passing. If you run yarn test in the components folder you should see it. If you have a look at other uses of not.toBeInTheDocument() you should be able to work out what needs fixing.

Oof, I remember I noticed that test failed and meant to fix it, but I guess I forgot about it. Thanks for the tip!

@CrowsVeldt
Copy link
Contributor Author

@benfurber I think I fixed it and I even remembered to run yarn format before committing this time :)

@CrowsVeldt CrowsVeldt requested a review from benfurber January 20, 2025 18:33
@cypress Cypress
Copy link

cypress bot commented Jan 20, 2025 •
edited
Loading

onearmy-community-platform    Run #6827

Run Properties:  status check passed Passed #6827  •  git commit ac06b9b594: feat: if accordion is closed clicking anywhere on it will open it
Project onearmy-community-platform
Branch Review pull/4080
Run status status check passed Passed #6827
Run duration 05m 43s
Commit git commit ac06b9b594: feat: if accordion is closed clicking anywhere on it will open it
Committer CrowsVeldt
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 79
View all changes introduced in this branch ↗︎

@CrowsVeldt
Copy link
Contributor Author

I see it failed a test. Looking at it now.

@benfurber benfurber force-pushed the accordion-component branch from 2432062 to a4d8776 Compare January 22, 2025 16:10
@benfurber
Copy link
Member

@all-contributors add CrowsVeldt for code

@allcontributors AllContributors
Copy link
Contributor

@benfurber

@CrowsVeldt already contributed before to code

@benfurber
Copy link
Member

@all-contributors add CrowsVeldt for design

@allcontributors allcontributors bot mentioned this pull request Jan 22, 2025
Closed
@allcontributors AllContributors
Copy link
Contributor

@benfurber

I've put up a pull request to add @CrowsVeldt! 🎉

@CrowsVeldt
Copy link
Contributor Author

@all-contributors add CrowsVeldt for design

Thanks!

@allcontributors allcontributors bot mentioned this pull request Jan 22, 2025
Closed
@allcontributors AllContributors
Copy link
Contributor

@CrowsVeldt

I've put up a pull request to add @CrowsVeldt! 🎉

@CrowsVeldt
Copy link
Contributor Author

@benfurber Oops. I didn't realize quoting that comment would re-trigger the bot. Sorry

@benfurber
Copy link
Member

@CrowsVeldt Looks like there's still a related cypress test failure.

@CrowsVeldt
Copy link
Contributor Author

@benfurber Right, crap. I'll work on it

@CrowsVeldt
Copy link
Contributor Author

It took me a while because I was having trouble getting cypress to run on my computer, but in the end I realized I was trying to run it from the wrong directory. Doy.

This change worked locally. Not sure how it'll go in the cloud. Fingers crossed.

@CrowsVeldt CrowsVeldt requested a review from benfurber January 25, 2025 14:37
@benfurber benfurber merged commit 39fe0a1 into ONEARMY:master Jan 27, 2025
18 checks passed
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfurber benfurber Awaiting requested review from benfurber

Assignees
No one assigned
Labels
released Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
Core Team - BAU list
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add accordion for settings form
3 participants
@CrowsVeldt @benfurber @onearmy-bot