Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: comment display to the component library #4094

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

benfurber
Copy link
Member

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the new behavior?

  1. Move a couple of UI focused components to the component library. (For easier contributor tickets about to be put up as issues)
  2. Rename V2 appended component names to Supabase appended component names.
  3. Move/tidy-up the new comment typing into shared.

Does this PR introduce a DB Schema Change or Migration?

  • Yes
  • No

@benfurber benfurber requested a review from a team as a code owner January 22, 2025 15:00
@benfurber benfurber force-pushed the refactor/new-comment-components branch from f015bca to d29b884 Compare January 22, 2025 15:09
@benfurber benfurber force-pushed the refactor/new-comment-components branch from d29b884 to 4bbe7c5 Compare January 22, 2025 15:23
Copy link

cypress bot commented Jan 22, 2025

onearmy-community-platform    Run #6818

Run Properties:  status check passed Passed #6818  •  git commit 4bbe7c5437: refactor: comment display to the component library
Project onearmy-community-platform
Branch Review pull/4094
Run status status check passed Passed #6818
Run duration 05m 35s
Commit git commit 4bbe7c5437: refactor: comment display to the component library
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 79
View all changes introduced in this branch ↗︎

@benfurber
Copy link
Member Author

Are you OK with this @mariojsnunes? If so do you mind merging in as I'm not back until Monday.

@benfurber benfurber merged commit c7b0304 into ONEARMY:master Jan 27, 2025
18 checks passed
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants