Skip to content

Conversation

@broadpeter
Copy link
Contributor

Integrates stacked column and stacked column and line in one template (also integrates the SM versions in that template). Also updates style (diamond markers)

Once this is merged, the column chart and column chart sm (those without lines) can be deleted/moved to archive or garage

Options in config:

  • to select a series to show as either markers only or markers and line, and to set the column name of the series for the line
    showMarkers: true,
    showLine: true,
    line_series: "Total".

Copy link
Contributor

@henryjameslau henryjameslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you do make the chart stacked column, ie turn off the line. If you put set line_series to blank ""or null, means the series is plotted. Could you add a note in the config how to remove the line e.g. set line_series to a blank string and remove it from the data.

Can we remove the existing folders if we don't need them and update the chart menu.
I feel like these templates don't need the -with-line in the title

@broadpeter
Copy link
Contributor Author

So delete the column-chart-stacked(-sm) templates and give these those names? Makes sense!

Copy link
Contributor

@nrennie nrennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's been a few updates to the repo since this was forked, so as well as fixing conflicts:

  • remove essential/optional split from config
  • use camelCase for config option names
  • add a README.md (even if blank) to each template folder (although maybe add a note about to how switch off the line)
  • use palette variables instead of hex codes in config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants