Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneccesary references to party business ref #336

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _infra/helm/collection-exercise/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 13.0.32
version: 13.0.33

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 13.0.32
appVersion: 13.0.33

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ public void shouldTransitionCollectionExerciseToReadyToReviewOnSampleSummaryLink
// Given
stubSurveyServiceBusiness();
stubCollectionInstrumentCount();
stubGetPartyBySampleUnitRef();
SampleSummaryDTO sampleSummary = stubSampleSummary();
UUID collectionExerciseId = createScheduledCollectionExercise();

Expand All @@ -199,7 +198,6 @@ public void shouldTransitionWhenToldSampleIsReady() throws Exception {
// Given
stubSurveyServiceBusiness();
stubCollectionInstrumentCount();
stubGetPartyBySampleUnitRef();
SampleSummaryDTO sampleSummary = stubSampleSummary();
UUID collectionExerciseId = createScheduledCollectionExercise();
this.client.linkSampleSummary(collectionExerciseId, sampleSummary.getId());
Expand All @@ -218,7 +216,6 @@ public void shouldNotTransitionWhenSampleIsNotReady() throws Exception {
// Given
stubSurveyServiceBusiness();
stubCollectionInstrumentCount();
stubGetPartyBySampleUnitRef();
SampleSummaryDTO sampleSummary = stubInitSampleSummary();
UUID collectionExerciseId = createScheduledCollectionExercise();
this.client.linkSampleSummary(collectionExerciseId, sampleSummary.getId());
Expand Down Expand Up @@ -332,46 +329,6 @@ private void stubCollectionInstrumentCount() throws IOException {
.willReturn(aResponse().withBody("1")));
}

private void stubGetPartyBySampleUnitRef() throws IOException {
String json =
loadResourceAsString(
CollectionExerciseEndpointIT.class,
"CollectionExerciseEndpointIT.PartyDTO.with-associations.json");
this.wireMockRule.stubFor(
get(urlPathMatching("/party-api/v1/businesses/ref/(.*)"))
.willReturn(aResponse().withHeader("Content-Type", "application/json").withBody(json)));
}

private void stubGetPartyNoAssociations() throws IOException {
String json =
loadResourceAsString(
CollectionExerciseEndpointIT.class,
"CollectionExerciseEndpointIT.PartyDTO.no-associations.json");
this.wireMockRule.stubFor(
get(urlPathMatching("/party-api/v1/businesses/ref/(.*)"))
.willReturn(aResponse().withHeader("Content-Type", "application/json").withBody(json)));
}

private void stubGetPartyWithAssociations() throws IOException {
String json =
loadResourceAsString(
CollectionExerciseEndpointIT.class,
"CollectionExerciseEndpointIT.Supplementary.with-associations.json");
this.wireMockRule.stubFor(
get(urlPathMatching("/party-api/v1/businesses/ref/(.*)"))
.willReturn(aResponse().withHeader("Content-Type", "application/json").withBody(json)));
}

private void stubGetSupplementaryDataServvice() throws IOException {
String json =
loadResourceAsString(
CollectionExerciseEndpointIT.class,
"CollectionExerciseEndpointIT.SupplementaryDatasetDTO.with-associations.json");
this.wireMockRule.stubFor(
get(urlPathMatching("/party-api/v1/businesses/ref/(.*)"))
.willReturn(aResponse().withHeader("Content-Type", "application/json").withBody(json)));
}

private void createSurveyServiceClassifierStubs() throws IOException {
String json =
loadResourceAsString(
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading