Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added variable declarations to fragment_invocation.ftl. #92

Merged
merged 1 commit into from
May 14, 2024

Conversation

rousso
Copy link
Contributor

@rousso rousso commented May 10, 2024

TEDEFO-3342 is a bug that talks about the need to declare XSL variables for each EFXT variable so that subsequently declared variables can reference previously declared ones. The previous implementation attempted to evaluate the variable initialisers directly when declared variables are passed as parameters to child EFX blocks. This does not allow referencing other variables in a variable initialiser because parameters cannot be referenced by name. The fix declares and initialises the variables before passing on their values to xsl:call-template as parameters.

@rousso rousso requested a review from bertrand-lorentz May 10, 2024 17:44
@rousso rousso self-assigned this May 10, 2024
Copy link
Contributor

@bertrand-lorentz bertrand-lorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the unit tests pass, I guess the syntax $${var} works as expected.

@rousso rousso merged commit 3516fd5 into develop May 14, 2024
1 check passed
@rousso rousso deleted the bugfix/TEFEO-3342-declare-xpath-variables branch May 14, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants