Skip to content

139 invalid parent node #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Archie-Miller merged 2 commits into from
Jan 13, 2026
+15 −41
Merged

139 invalid parent node #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c11176
Found more effective way to get parent node id using reverse references.
Archie-Miller Jan 12, 2026
c06cb15
Testing for issue 139
Archie-Miller Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 9 additions & 41 deletions NodeSetToAML.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2438,19 +2438,6 @@ private string GetExistingCreatedPathName(UANode node)
return createdPathName;
}

private string EqualizeParentNodeId(UAInstance node, string parentNodeId)
{
string[] parentSplit = parentNodeId.Split(";");
if ( parentSplit.Length > 1)
{
ModelInfo modelInfo = m_modelManager.FindModel(node.DecodedNodeId);
parentNodeId = String.Format("ns={0};{1}",
modelInfo.NamespaceIndex, parentSplit[1]);
}

return parentNodeId;
}

private string GetCreatedPathName(UANode node)
{
string pathName = GetExistingCreatedPathName(node);
Expand All @@ -2460,40 +2447,21 @@ private string GetCreatedPathName(UANode node)
UAInstance uaInstance = node as UAInstance;
if (uaInstance != null )
{
string parentNodeIdString = string.Empty;

if ( uaInstance.ParentNodeId != null )
{
parentNodeIdString = uaInstance.ParentNodeId;
}
else
var refList = m_modelManager.FindReferences( node.DecodedNodeId );
foreach( var reference in refList )
{
var refList = m_modelManager.FindReferences( node.DecodedNodeId );
int reversePropertyCount = 0;
foreach( var reference in refList )
if( reference.IsForward == false &&
( reference.ReferenceTypeId.Equals(HasPropertyNodeId) ||
reference.ReferenceTypeId.Equals( Opc.Ua.ReferenceTypeIds.HasComponent ) ) )
{
if( reference.IsForward == false &&
( reference.ReferenceTypeId.Equals(HasPropertyNodeId) ||
reference.ReferenceTypeId.Equals( Opc.Ua.ReferenceTypeIds.HasComponent ) ) )
UANode parentNodeId = m_modelManager.FindNode<UANode>( reference.TargetId );
if ( parentNodeId != null )
{
UANode parentNodeId = m_modelManager.FindNode<UANode>( reference.TargetId );
if ( parentNodeId != null )
{
parentNodeIdString = parentNodeId.NodeId;
break;
}

reversePropertyCount++;
pathName = GetCreatedPathName(parentNodeId);
break;
}
}
}

if ( parentNodeIdString.Length > 0)
{
string parentNodeId = EqualizeParentNodeId(uaInstance, parentNodeIdString);
UANode parentNode = FindNode<NodeSet.UANode>(new NodeId(parentNodeId));
pathName = GetCreatedPathName(parentNode);
}
}

if (pathName.Length > 0)
Expand Down
6 changes: 6 additions & 0 deletions SystemTest/TestNonHierarchical.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ public class TestNonHierarchical
TestHelper.Uris.AmlFxTest, 5008u,
DisplayName = "Instance Hosts")]

[DataRow("", TestHelper.Uris.Root, 14156u,
"HasCondition",
TestHelper.Uris.Root, Opc.Ua.ObjectTypes.CertificateExpirationAlarmType,
DisplayName = "DefaultApplication Group to Audit Event Issue 139")]


public void TestReference(string prefix, TestHelper.Uris testUri, uint testNodeId, string referenceName,
TestHelper.Uris targetUri, uint targetNodeId)
{
Expand Down