feat(preview) : #MAG-194 add arrows on preview to navigate between cards #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niko-amosse
approved these changes
Jan 7, 2025
JinDouang
requested changes
Jan 8, 2025
| @@ -37,50 +46,121 @@ export const PreviewModal: FC = () => { | |||
| } | |||
| }, [COMMENT_PANEL]); | |||
|
|
|||
| const initialCards = useMemo(() => { | |||
| return board.isLayoutFree() | |||
There was a problem hiding this comment.
Code dupliqué par rapport à la ligne 69
| }; | ||
|
|
||
| const isLastCardInBoard = (): boolean => { | ||
| const cards = board.isLayoutFree() ? board.cards : initialCards; |
There was a problem hiding this comment.
Comme tu appelles quoi qu'il arrive initialCards dans laquelle tu répètes la même instruction, tu pourrais refactoriser cette partie ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
add arrows on preview to navigate between cards
Checklist tests
Check any board types and card types, check if the buttons are there and if keyboard left and right arrow work.
Issue ticket number and link
MAG-194
Checklist before requesting a review (magic string, indentation, comment/documentation...)