Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmrpp new reorg #811

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Dmrpp new reorg #811

wants to merge 22 commits into from

Conversation

jgallagher59701
Copy link
Member

Dmrpp new reorg. I'm floating this as an idea more than a real PR. Is this a good/better/useful way to organize our handlers that employ specializations of the libdap type classes? This came about while trying to get the casting to work for Kent's code.

I also fixed a number of bugs in the Makefile.am files in DMR++.

@jgallagher59701
Removed generated file
a89bf4e
@jgallagher59701
Revert "Removed generated file"
dc627fe 
This reverts commit a89bf4e.
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
a2671a3
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
6cedd18
@jgallagher59701
Fail configure when building and lindap is not found.
34e3266
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
af454b2
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
3d605aa
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
8e7f144
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
f8cebb0
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
c19b79b
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
cfbad60
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
70c8341
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
ee39743
@jgallagher59701
Merge branch 'master' of https://github.com/OPENDAP/bes
0df0c7c
@jgallagher59701
DMR++ module code reorganization
21403a1
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 38 Bugs
Vulnerability D 1 Vulnerability
Security Hotspot E 2 Security Hotspots
Code Smell A 754 Code Smells

0.0% 0.0% Coverage
1.4% 1.4% Duplication

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jgallagher59701
Merge branch 'master' into dmrpp-new-reorg
44d5996
@jgallagher59701
Updates to two Makefile.am files in the DMR++ code
9d1bcf0
@jgallagher59701
Fixed issues with the Makefile.am files and with CurlHandlePool
f914117 
For CurlHandlePool, using a unique_ptr seems to make the code touchy
when it comes to allocating the parent/containing object using new
and initializing the unique_ptr to nullptr. I replaced that initialization
with ...=make_unique<CurlHandlePool> and the seg faults went away.
@jgallagher59701
Sonar issues
d69edf2
@jgallagher59701
Indentation and a #define.
5e0973c
@jgallagher59701
One last exception fixed
d91d03e
@jgallagher59701
More refactoring
1cf4502
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 683 Code Smells

0.0% 0.0% Coverage
1.3% 1.3% Duplication

@jgallagher59701 jgallagher59701 marked this pull request as ready for review October 26, 2023 15:26
@jgallagher59701
Copy link
Member Author

Nathan, Kent,

This PR changes how the DMR++ code is organized so that it's possible to use the DmrppArray, etc., classes in other handlers. At least in theory, I have not tried that yet. I will, but before I jump in that I'd like to know how much disruption will cause for work you have going.

kyang2014
kyang2014 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@kyang2014 kyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged this branch to the current direct IO branch and tested it. It can compile and all the tests get passed. So this merge is OK for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyang2014 kyang2014 kyang2014 approved these changes

@ndp-opendap ndp-opendap Awaiting requested review from ndp-opendap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgallagher59701 @kyang2014