Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elevator questions #271

Merged
merged 43 commits into from
Jul 22, 2024
Merged

Conversation

wielandb
Copy link
Contributor

@wielandb wielandb commented Jul 1, 2024

This PR adds some questions that relate to the recent "Evelator dimensions" proposal.

These questions are:

  • What shape does this elevator have?
  • What's the diameter of this elevator?
  • How tall is the cabin of this elevator?
  • How wide is the door of this elevator?
  • How tall is the door of this elevator?

It modifies the questions

  • How wide is this elevator?
  • How deep is this elevator?
    to only be asked if the elevator has a rectangular shape

It does not ask for any max*:physical=*values as this is currently not possible with this app.

Currently missing:

  • Example images

@wielandb wielandb marked this pull request as ready for review July 2, 2024 10:14
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/de.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
@wielandb
Copy link
Contributor Author

wielandb commented Jul 9, 2024

The JSON validation fails.

I don't really understand what's wrong about

            "max": 4,
            "unit": "@unitCentimeter"
         },
         "constructor": {
            "diameter": ["CONCAT", "$input", "m"]
         }
      },

assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/locales/de.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/locales/de.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/de.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/de.arb Outdated Show resolved Hide resolved
assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
Copy link
Member

@Robbendebiene Robbendebiene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move all new elevator questions right below the elevator width/length questions.

assets/question_catalog/definition.json Outdated Show resolved Hide resolved
assets/question_catalog/definition.json Outdated Show resolved Hide resolved
wielandb and others added 3 commits July 22, 2024 10:19
Co-authored-by: Robin Thomas <Robbendebiene@users.noreply.github.com>
Co-authored-by: Robin Thomas <Robbendebiene@users.noreply.github.com>
@Robbendebiene Robbendebiene merged commit 5e3b3b1 into OPENER-next:master Jul 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants