-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elevator questions #271
Merged
Robbendebiene
merged 43 commits into
OPENER-next:master
from
wielandb:elevator-questions
Jul 22, 2024
Merged
Add elevator questions #271
Robbendebiene
merged 43 commits into
OPENER-next:master
from
wielandb:elevator-questions
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7h30n3
requested changes
Jul 3, 2024
Robbendebiene
requested changes
Jul 8, 2024
The JSON validation fails. I don't really understand what's wrong about
|
Robbendebiene
requested changes
Jul 10, 2024
Robbendebiene
requested changes
Jul 11, 2024
Robbendebiene
requested changes
Jul 16, 2024
Robbendebiene
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move all new elevator questions right below the elevator width/length questions.
Co-authored-by: Robin Thomas <Robbendebiene@users.noreply.github.com>
Co-authored-by: Robin Thomas <Robbendebiene@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some questions that relate to the recent "Evelator dimensions" proposal.
These questions are:
It modifies the questions
to only be asked if the elevator has a rectangular shape
It does not ask for any
max*:physical=*
values as this is currently not possible with this app.Currently missing: